Ensure t.try() assigns unique titles when multiple implementations are passed

Author: novemberborn

lib/test.js

@@ -79,11 +79,11 @@ class ExecutionContext extends assert.Assertions {
 				throw new TypeError('Expected an implementation.');
 			}
 
-			const attemptPromises = implementations.map(implementation => {
+			const attemptPromises = implementations.map((implementation, index) => {
 				let {title, isSet, isValid, isEmpty} = buildTitle(implementation);
 
 				if (!isSet || isEmpty) {
-					title = `${test.title} ─ attempt ${test.attemptCount + 1}`;
+					title = `${test.title} ─ attempt ${test.attemptCount + 1 + index}`;
 				} else if (isValid) {
 					title = `${test.title} ─ ${title}`;
 				} else {

test/helper/ava-test.js

@@ -2,15 +2,25 @@ const Test = require('../../lib/test');
 const ContextRef = require('../../lib/context-ref');
 
 function withExperiments(experiments = {}) {
-	function ava(fn, contextRef) {
+	const uniqueTestTitles = new Set();
+	const registerUniqueTitle = title => {
+		if (uniqueTestTitles.has(title)) {
+			return false;
+		}
+
+		uniqueTestTitles.add(title);
+		return true;
+	};
+
+	function ava(fn, contextRef, title = 'test') {
 		return new Test({
 			contextRef: contextRef || new ContextRef(),
 			experiments,
 			failWithoutAssertions: true,
 			fn,
-			registerUniqueTitle: () => true,
+			registerUniqueTitle,
 			metadata: {type: 'test', callback: false},
-			title: 'test'
+			title
 		});
 	}
 
@@ -20,7 +30,7 @@ function withExperiments(experiments = {}) {
 			experiments,
 			failWithoutAssertions: true,
 			fn,
-			registerUniqueTitle: () => true,
+			registerUniqueTitle,
 			metadata: {type: 'test', callback: false, failing: true},
 			title: 'test.failing'
 		});
@@ -32,7 +42,7 @@ function withExperiments(experiments = {}) {
 			experiments,
 			failWithoutAssertions: true,
 			fn,
-			registerUniqueTitle: () => true,
+			registerUniqueTitle,
 			metadata: {type: 'test', callback: true},
 			title: 'test.cb'
 		});
@@ -44,7 +54,7 @@ function withExperiments(experiments = {}) {
 			experiments,
 			failWithoutAssertions: true,
 			fn,
-			registerUniqueTitle: () => true,
+			registerUniqueTitle,
 			metadata: {type: 'test', callback: true, failing: true},
 			title: 'test.cb.failing'
 		});