Skip to content

Commit 1ff91d5

Browse files
committed
resolve comments
1 parent a57f07e commit 1ff91d5

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

template.ipynb

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"* Bad example filename: *amazon_sagemaker-processing-images_with_pytorch_on_GPU.ipynb* (too long & mixes case, dashes, and underscores)\n",
1313
"* Good example filename: *processing_images_pytorch_gpu.ipynb* (succinct, all lowercase, all underscores)\n",
1414
"\n",
15+
"**IMPORTANT:** Use only one maining heading with `#`, so your next subheading is `##` or `###` and so on.\n",
1516
"\n",
1617
"## Overview\n",
1718
"1. What does this notebook do?\n",
@@ -47,7 +48,7 @@
4748
"1. Describe any pip or conda or apt installs or setup scripts that are needed.\n",
4849
"1. Pin sagemaker if version <2 is required.\n",
4950
"\n",
50-
" `!{sys.executable} -m pip install \"sagemaker>=1.14.2,<2\"`\n",
51+
" `%pip install \"sagemaker>=1.14.2,<2\"`\n",
5152
" \n",
5253
" \n",
5354
"1. Upgrade sagemaker if version 2 is required, but rollback upgrades to packages that might taint the user's kernel and make other notebooks break. Do this at the end of the notebook in the cleanup cell.\n",
@@ -56,10 +57,10 @@
5657
" # setup\n",
5758
" import sagemaker\n",
5859
" version = sagemaker.__version__\n",
59-
" !{sys.executable} -m pip install 'sagemaker>=2.0.0'\n",
60+
" %pip install 'sagemaker>=2.0.0'\n",
6061
" ...\n",
6162
" # cleanup\n",
62-
" !{sys.executable} -m pip install 'sagemaker=={}'.format(version)\n",
63+
" %pip install 'sagemaker=={}'.format(version)\n",
6364
" ```\n",
6465
" \n",
6566
"\n",
@@ -74,7 +75,7 @@
7475
"source": [
7576
"# SageMaker Python SDK version 1.x is required\n",
7677
"import sys\n",
77-
"!{sys.executable} -m pip install -U \"sagemaker>=1.14.2,<2\""
78+
"%pip install \"sagemaker>=1.14.2,<2\""
7879
]
7980
},
8081
{
@@ -87,7 +88,7 @@
8788
"import sagemaker\n",
8889
"import sys\n",
8990
"original_version = sagemaker.__version__\n",
90-
"!{sys.executable} -m pip install 'sagemaker>=2.0.0'"
91+
"%pip install 'sagemaker>=2.0.0'"
9192
]
9293
},
9394
{
@@ -225,7 +226,7 @@
225226
"print(\"Current version: {}\".format(sagemaker.__version__))\n",
226227
"s = 'sagemaker=={}'.format(version)\n",
227228
"print(\"Rolling back to... {}\".format(s))\n",
228-
"!{sys.executable} -m pip install {s}\n",
229+
"%pip install {s}\n",
229230
"import sagemaker\n",
230231
"print(\"{} installed!\".format(sagemaker.__version__))"
231232
]

0 commit comments

Comments
 (0)