Skip to content

Commit 4be9de6

Browse files
committed
Disable test for deprecated CATCH_CONFIG_BAZEL_SUPPORT option
Because it requires full rebuild of the base library, it adds about 20% to the build time of the test suite. Between the fact that the option is deprecated, and that Bazel has added the `BAZEL_TEST` env var _years_ ago, nobody should be using it, and the chance of breakage is tiny, the test is not worth its compile-time cost.
1 parent 91b3b3b commit 4be9de6

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

tests/ExtraTests/CMakeLists.txt

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -109,18 +109,6 @@ set_tests_properties(CATCH_CONFIG_DISABLE_EXCEPTIONS-1
109109
FAIL_REGULAR_EXPRESSION "abort;terminate;fatal"
110110
)
111111

112-
add_executable(BazelReporter ${TESTS_DIR}/X30-BazelReporter.cpp)
113-
target_compile_definitions(BazelReporter PRIVATE CATCH_CONFIG_BAZEL_SUPPORT)
114-
target_link_libraries(BazelReporter Catch2_buildall_interface)
115-
add_test(NAME CATCH_CONFIG_BAZEL_REPORTER-1
116-
COMMAND
117-
Python3::Interpreter "${CATCH_DIR}/tests/TestScripts/testBazelReporter.py" $<TARGET_FILE:BazelReporter> "${CMAKE_CURRENT_BINARY_DIR}"
118-
)
119-
set_tests_properties(CATCH_CONFIG_BAZEL_REPORTER-1
120-
PROPERTIES
121-
LABELS "uses-python"
122-
)
123-
124112
# We must now test this works without the build flag.
125113
add_executable(BazelReporterNoCatchConfig ${TESTS_DIR}/X30-BazelReporter.cpp)
126114
target_link_libraries(BazelReporterNoCatchConfig Catch2WithMain)

0 commit comments

Comments
 (0)