chore: update submission name pattern #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigzour
requested changes
May 22, 2025
|
Added the test obj |
craigzour
reviewed
May 22, 2025
There was a problem hiding this comment.
Looks good! Let's wait and see what is the priority on getting this to production (context: https://gcdigital.slack.com/archives/C01GFD150MC/p1747921792463709?thread_ts=1747830335.978189&cid=C01GFD150MC)
craigzour
approved these changes
May 27, 2025
craigzour
force-pushed
the
update-submission-name-pattern
branch
from
c4c3245 to
e7c50fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Update to handle legacy + new submission name based on
cds-snc/forms-terraform#1032