Skip to content

Commit 5417164

Browse files
committed
Merge branch 'qa'
2 parents 7e43202 + 5c5dcea commit 5417164

File tree

2 files changed

+11
-21
lines changed

2 files changed

+11
-21
lines changed

manifests/config.pp

Lines changed: 10 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
Optional[String] $backup_controller = undef,
2020
Optional[String] $backup_addr = $backup_controller,
2121
Integer[0,1] $allow_spec_resources_usage = 0,
22-
Enum['checkpoint/blcr','checkpoint/none','checkpoint/ompi','checkpoint/poe'] $checkpoint_type= 'checkpoint/none',
22+
Enum['checkpoint/none','checkpoint/ompi'] $checkpoint_type= 'checkpoint/none',
2323
Optional[String] $chos_loc = undef,
2424
Enum['core_spec/cray','core_spec/none'] $core_spec_plugin = 'core_spec/none',
2525
Enum['Conservative','OnDemand','Performance','PowerSave'] $cpu_freq_def = 'Performance',
@@ -38,15 +38,14 @@
3838
Integer[0,1] $job_requeue = 0,
3939
Optional[Array[String]] $job_submit_plugins = undef,
4040
Integer[0,1] $kill_on_bad_exit = 0,
41-
Enum['launch/aprun','launch/poe','launch/runjob','launch/slurm'] $launch_type = 'launch/slurm',
41+
Enum['launch/aprun','launch/runjob','launch/slurm'] $launch_type = 'launch/slurm',
4242
Optional[Array[Enum['mem_sort','slurmstepd_memlock','slurmstepd_memlock_all','test_exec']]] $launch_parameters = undef,
4343
Optional[Array[String]] $licenses = undef,
4444
Optional[Enum['node_features/knl_cray','node_features/knl_generic']] $node_features_plugins = undef,
4545
String $mail_prog = '/bin/mail',
4646
Optional[String] $mail_domain = undef,
4747
Integer[1] $max_job_count = 10000,
4848
Integer[1] $max_step_count = 40000,
49-
Enum['no','yes'] $mem_limit_enforce = 'no',
5049
Hash[Enum['WindowMsgs','WindowTime'],Integer[1]] $msg_aggregation_params = {'WindowMsgs' => 1, 'WindowTime' => 100},
5150
String $plugin_dir = '/usr/local/lib/slurm',
5251
Optional[String] $plug_stack_config = undef,
@@ -55,7 +54,7 @@
5554
Enum['preempt/none','preempt/partition_prio','preempt/qos'] $preempt_type = 'preempt/none',
5655
Array[Enum['OFF','CANCEL','CHECKPOINT','GANG','REQUEUE','SUSPEND']] $preempt_mode = ['OFF'],
5756
Optional[Array[Enum['accounts','cloud','jobs','nodes','partitions','reservations','usage','users']]] $private_data = undef,
58-
Optional[Enum['proctrack/cgroup','proctrack/cray','proctrack/linuxproc','proctrack/lua','proctrack/sgi_job','proctrack/pgid']] $proctrack_type = undef,
57+
Optional[Enum['proctrack/cgroup','proctrack/cray','proctrack/linuxproc','proctrack/pgid']] $proctrack_type = undef,
5958
Integer[0,2] $propagate_prio_process = 0,
6059
Optional[Array[Enum['ALL','NONE','AS','CORE','CPU','DATA','FSIZE','MEMLOCK','NOFILE','NPROC','RSS','STACK']]] $propagate_resource_limits = undef,
6160
Optional[Array[Enum['ALL','NONE','AS','CORE','CPU','DATA','FSIZE','MEMLOCK','NOFILE','NPROC','RSS','STACK']]] $propagate_resource_limits_except = undef,
@@ -79,7 +78,7 @@
7978
Optional[String] $srun_prolog = undef,
8079
Optional[String] $srun_port_range = undef,
8180
String $state_save_location = '/var/spool/slurmctld',
82-
Enum['switch/none','switch/nrt'] $switch_type = 'switch/none',
81+
Enum['switch/none'] $switch_type = 'switch/none',
8382
Array[Enum['task/affinity','task/cgroup','task/none']] $task_plugin = ['task/none'],
8483
Array[String] $task_plugin_param = ['Sched'],
8584
Optional[String] $task_epilog = undef,
@@ -91,9 +90,9 @@
9190

9291
Enum['auth/none','auth/munge'] $auth_type = 'auth/munge',
9392
Optional[String] $auth_info = undef,
94-
Enum['crypto/munge','crypto/openssl'] $crypto_type = 'crypto/munge',
9593
Optional[String] $job_credential_private_key = undef,
9694
Optional[String] $job_credential_public_certificate = undef,
95+
Enum['cred/munge'] $cred_type = 'cred/munge',
9796
Enum['mcs/account','mcs/group','mcs/none','mcs/user'] $mcs_plugin = 'mcs/none',
9897
Optional[String] $mcs_parameters = undef,
9998
Integer[0,1] $use_pam = 0,
@@ -144,12 +143,12 @@
144143
Integer[0] $scheduler_time_slice = 30,
145144
Enum['sched/backfill','sched/builtin','sched/hold'] $scheduler_type = 'sched/backfill',
146145
Optional[Array[String]] $scheduler_parameters = undef,
147-
Enum['select/bluegene','select/cons_res','select/cray','select/linear','select/serial'] $select_type = 'select/linear',
146+
Enum['select/bluegene','select/cons_res','select/cons_tres','select/cray','select/linear'] $select_type = 'select/linear',
148147
Optional[Array[Enum['OTHER_CONS_RES','NHC_ABSOLUTELY_NO','NHC_NO_STEPS','NHC_NO','CR_CPU','CR_CPU_Memory','CR_Core','CR_Core_Memory','CR_ONE_TASK_PER_CORE','CR_CORE_DEFAULT_DIST_BLOCK','CR_LLN','CR_Pack_Nodes','CR_Socket','CR_Socket_Memory','CR_Memory']]] $select_type_parameters = undef,
149148
Integer[0] $vsize_factor = 0,
150149

151150
Enum['priority/basic','priority/multifactor'] $priority_type = 'priority/basic',
152-
Optional[Array[Enum['ACCRUE_ALWAYS','CALCULATE_RUNNING','DEPTH_OBLIVIOUS','FAIR_TREE','INCR_ONLY','MAX_TRES','SMALL_RELATIVE_TO_TIME']]] $priority_flags = undef,
151+
Optional[Array[Enum['ACCRUE_ALWAYS','CALCULATE_RUNNING','DEPTH_OBLIVIOUS','NO_FAIR_TREE','INCR_ONLY','MAX_TRES','SMALL_RELATIVE_TO_TIME','NO_NORMAL_ALL','NO_NORMAL_ASSOC','NO_NORMAL_PART','NO_NORMAL_QOS','NO_NORMAL_TRES']]] $priority_flags = undef,
153152
Integer[0] $priority_calc_period = 5,
154153
String $priority_decay_half_life = '7-0',
155154
Enum['NO','YES'] $priority_favor_small = 'NO',
@@ -187,7 +186,7 @@
187186
Optional[String] $job_comp_pass = undef,
188187
Optional[String] $job_comp_loc = undef,
189188
Enum['jobacct_gather/linux','jobacct_gather/cgroup','jobacct_gather/none'] $job_acct_gather_type = 'jobacct_gather/none',
190-
Optional[Array[Enum['NoShared','UsePss','NoOverMemoryKill']]] $job_acct_gather_params = undef,
189+
Optional[Array[Enum['NoShared','UsePss','OverMemoryKill']]] $job_acct_gather_params = undef,
191190
Hash[Enum['task','energy','network','filesystem'],Integer[0]] $job_acct_gather_frequency = {'task' => 30,'energy' => 0,'network' => 0,'filesystem' => 0},
192191
Integer[0] $acct_gather_node_freq = 0,
193192
Enum['acct_gather_energy/none','acct_gather_energy/ipmi','acct_gather_energy/rapl'] $acct_gather_energy_type = 'acct_gather_energy/none',
@@ -244,7 +243,7 @@
244243

245244
# Authentication service for SLURM if MUNGE is used as authentication plugin
246245
if ($auth_type == 'auth/munge') or
247-
($crypto_type == 'crypto/munge') {
246+
($cred_type == 'cred/munge') {
248247

249248
ensure_packages($munge_packages, {'ensure' => $munge_version})
250249

@@ -315,14 +314,6 @@
315314
}
316315
}
317316

318-
# If openssl will be used for the crypto plugin, the key pair is a required file
319-
if $crypto_type == 'crypto/openssl' {
320-
$openssl_credential_files = [$job_credential_private_key,$job_credential_public_certificate]
321-
}
322-
else {
323-
$openssl_credential_files = []
324-
}
325-
326317
if $cluster_name != undef {
327318
$shared_config_filepath = "${shared_config_path}/${cluster_name}.conf"
328319
} else {
@@ -433,6 +424,6 @@
433424
'/etc/slurm/slurm.conf',
434425
]
435426

436-
$required_files = concat($openssl_credential_files, $acct_gather_conf_file, $cgroup_conf_file, $topology_conf_file, $gres_conf_file, $common_config_files)
427+
$required_files = concat($acct_gather_conf_file, $cgroup_conf_file, $topology_conf_file, $gres_conf_file, $common_config_files)
437428

438429
}

templates/slurm.conf.erb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ MailProg=<%= @mail_prog %>
6363
<%= @mail_domain.nil? ? '#MailDomain=' : ('MailDomain=' + @mail_domain) %>
6464
MaxJobCount=<%= @max_job_count %>
6565
MaxStepCount=<%= @max_step_count %>
66-
MemLimitEnforce=<%= @mem_limit_enforce %>
6766
MsgAggregationParams=<%= @msg_aggregation_params.map{|pair| pair.join('=')}.join(',') %>
6867
PluginDir=<%= @plugin_dir %>
6968
<%= @plug_stack_config.nil? ? '#PlugStackConfig=' : ('PlugStackConfig=' + @plug_stack_config) %>
@@ -164,7 +163,7 @@ TrackWCKey=<%= @track_wckey %>
164163
# SECURITY
165164
AuthType=<%= @auth_type %>
166165
<%= @auth_info.nil? ? '#AuthInfo=' : ('AuthInfo=' + @auth_info) %>
167-
CryptoType=<%= @crypto_type %>
166+
CredType=<%= @cred_type %>
168167
<%= @job_credential_private_key.nil? ? '#JobCredentialPrivateKey=' : ('JobCredentialPrivateKey=' + @job_credential_private_key) %>
169168
<%= @job_credential_public_certificate.nil? ? '#JobCredentialPublicCertificate=' : ('JobCredentialPublicCertificate=' + @job_credential_public_certificate) %>
170169
MCSPlugin=<%= @mcs_plugin %>

0 commit comments

Comments
 (0)