Reland "VT: Remove containment requirement."

This reverts commit f2820f7.

This was reverted earlier to wait for CSSWG feedback. The resolution
aligns with the behaviour in this patch.

w3c/csswg-drafts#8139

Original change's description:
> Revert "VT: Remove containment requirement."
>
> This reverts commit e554cf3.
>
> Reason for revert: Decided against this feature for now.
>
> Original change's description:
> > VT: Remove containment requirement.
> >
> > This patch removes the containment requirement from view-transitions.
> >
> > This is to align with proposed resolution
> >  w3c/csswg-drafts#7882
> >
> > R=​[email protected], [email protected]
> >
> > Fixed: 1409491
> > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> > Reviewed-by: David Bokan <[email protected]>
> > Reviewed-by: Khushal Sagar <[email protected]>
> > Commit-Queue: Vladimir Levin <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1096187}
>
> Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
> Commit-Queue: Vladimir Levin <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096273}

(cherry picked from commit 652c5ff)

Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087
Commit-Queue: Vladimir Levin <[email protected]>
Commit-Queue: Khushal Sagar <[email protected]>
Auto-Submit: Khushal Sagar <[email protected]>
Reviewed-by: Vladimir Levin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1102856}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233792
Commit-Queue: Xianzhu Wang <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/5563@{#318}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}

Author: khushalsagar

third_party/blink/renderer/core/view_transition/view_transition_style_tracker.cc

@@ -46,9 +46,6 @@
 namespace blink {
 namespace {
 
-const char* kContainmentNotSatisfied =
-    "Aborting transition. Element must contain paint or layout for "
-    "view-transition-name : ";
 const char* kDuplicateTagBaseError =
     "Unexpected duplicate view-transition-name: ";
 
@@ -66,11 +63,6 @@ const String& AnimationUAStyles() {
   return kAnimationUAStyles;
 }
 
-bool SatisfiesContainment(const LayoutObject& object) {
-  return object.ShouldApplyPaintContainment() ||
-         object.ShouldApplyLayoutContainment();
-}
-
 absl::optional<String> ComputeInsetDifference(PhysicalRect reference_rect,
                                               const LayoutRect& target_rect,
                                               float device_pixel_ratio) {
@@ -353,25 +345,6 @@ bool ViewTransitionStyleTracker::FlattenAndVerifyElements(
     VectorOf<Element>& elements,
     VectorOf<AtomicString>& transition_names,
     absl::optional<RootData>& root_data) {
-  for (const auto& element : ViewTransitionSupplement::From(*document_)
-                                 ->ElementsWithViewTransitionName()) {
-    DCHECK(element->ComputedStyleRef().ViewTransitionName());
-
-    // Ignore elements which are not rendered.
-    if (!element->GetLayoutObject())
-      continue;
-
-    // Skip the transition if containment is not satisfied.
-    if (!element->IsDocumentElement() &&
-        !SatisfiesContainment(*element->GetLayoutObject())) {
-      StringBuilder message;
-      message.Append(kContainmentNotSatisfied);
-      message.Append(element->ComputedStyleRef().ViewTransitionName());
-      AddConsoleError(message.ReleaseString());
-      return false;
-    }
-  }
-
   // We need to flatten the data first, and sort it by ordering which reflects
   // the setElement ordering.
   struct FlatData : public GarbageCollected<FlatData> {
@@ -826,11 +799,9 @@ bool ViewTransitionStyleTracker::RunPostPrePaintSteps() {
 
     DCHECK_NE(element_data->target_element, document_->documentElement());
     auto* layout_object = element_data->target_element->GetLayoutObject();
-    if (!layout_object || !SatisfiesContainment(*layout_object)) {
-      StringBuilder message;
-      message.Append(kContainmentNotSatisfied);
-      message.Append(entry.key);
-      AddConsoleError(message.ReleaseString());
+    // TODO(khushalsagar): Verify that skipping a transition when things become
+    // display none is aligned with spec.
+    if (!layout_object) {
       return false;
     }
 

third_party/blink/web_tests/external/wpt/css/css-view-transitions/3d-transform-incoming-ref.html

@@ -15,7 +15,6 @@
   background: blue;
 }
 .shared {
-  contain: layout;
   width: 100px;
   height: 100px;
 }

third_party/blink/web_tests/external/wpt/css/css-view-transitions/3d-transform-incoming.html

@@ -25,7 +25,6 @@
 }
 .shared {
   view-transition-name: shared;
-  contain: layout;
   width: 100px;
   height: 100px;
 }
@@ -34,7 +33,6 @@
   width: 10px;
   height: 10px;
   background: red;
-  contain: layout;
 }
 
 ::view-transition-group(hidden) { animation-duration: 300s; }

third_party/blink/web_tests/external/wpt/css/css-view-transitions/3d-transform-outgoing-ref.html

@@ -9,7 +9,6 @@
   background: green;
 }
 .shared {
-  contain: layout;
   width: 100px;
   height: 100px;
 }

third_party/blink/web_tests/external/wpt/css/css-view-transitions/3d-transform-outgoing.html

@@ -26,7 +26,6 @@
 }
 .shared {
   view-transition-name: shared;
-  contain: layout;
   width: 100px;
   height: 100px;
 }
@@ -35,7 +34,6 @@
   width: 10px;
   height: 10px;
   background: red;
-  contain: layout;
 }
 
 ::view-transition-group(hidden) { animation-duration: 300s; }

third_party/blink/web_tests/external/wpt/css/css-view-transitions/css-tags-paint-order-ref.html

@@ -5,7 +5,6 @@
 
 <style>
 div {
-  contain: layout;
   position: absolute;
   top: 50px;
   width: 100px;

third_party/blink/web_tests/external/wpt/css/css-view-transitions/css-tags-paint-order.html

@@ -7,7 +7,6 @@
 
 <script src="/common/reftest-wait.js"></script>
 <style>
-div { contain: layout; }
 #one {
   background: green;
   width: 100px;

third_party/blink/web_tests/external/wpt/css/css-view-transitions/dialog-in-top-layer-during-transition-new.html

@@ -17,7 +17,6 @@
   padding: 0;
 
   view-transition-name: dialog;
-  contain: layout;
 }
 
 #target::backdrop {
@@ -26,7 +25,6 @@
   background: grey;
 
   view-transition-name: backdrop;
-  contain: layout;
 }
 
 .hidden {

third_party/blink/web_tests/external/wpt/css/css-view-transitions/dialog-in-top-layer-during-transition-old.html

@@ -17,7 +17,6 @@
   padding: 0;
 
   view-transition-name: dialog;
-  contain: layout;
 }
 
 #target::backdrop {
@@ -26,7 +25,6 @@
   background: grey;
 
   view-transition-name: backdrop;
-  contain: layout;
 }
 
 .hidden {

third_party/blink/web_tests/external/wpt/css/css-view-transitions/element-with-overflow.html

@@ -12,14 +12,12 @@
     height: 10px;
     view-transition-name: hidden;
     background: green;
-    contain: layout;
   }
 
   .target {
     width: 100px;
     height: 100px;
     background: lightblue;
-    contain: layout;
     view-transition-name: target;
   }
   .inner {

third_party/blink/web_tests/external/wpt/css/css-view-transitions/named-element-with-fix-pos-child-new.html

@@ -0,0 +1,45 @@
+<!DOCTYPE html>
+<html class=reftest-wait>
+<title>View transitions: element with fixed position descendant</title>
+<link rel="help" href="https://github.com/WICG/view-transitions">
+<link rel="author" href="mailto:[email protected]">
+<link rel="match" href="named-element-with-fix-pos-child-ref.html">
+<script src="/common/reftest-wait.js"></script>
+<style>
+.target {
+  width: 100px;
+  height: 100px;
+  background: blue;
+  view-transition-name: target;
+}
+.child {
+  width: 100px;
+  height: 100px;
+  position: fixed;
+  top: 150px;
+  left: 150px;
+  background: grey;
+}
+
+html::view-transition-group(target) { animation-duration: 300s; }
+html::view-transition-old(target) { animation: unset; opacity: 0; }
+html::view-transition-new(target) {
+  animation: unset;
+  opacity: 1;
+}
+</style>
+
+<div class=target>
+  <div class=child></div>
+</div>
+
+<script>
+failIfNot(document.startViewTransition, "Missing document.startViewTransition");
+
+async function runTest() {
+  document.startViewTransition(() =>
+    requestAnimationFrame(() => requestAnimationFrame(takeScreenshot)));
+}
+onload = () => requestAnimationFrame(() => requestAnimationFrame(runTest));
+</script>
+

third_party/blink/web_tests/external/wpt/css/css-view-transitions/named-element-with-fix-pos-child-old.html

@@ -0,0 +1,45 @@
+<!DOCTYPE html>
+<html class=reftest-wait>
+<title>View transitions: element with fixed position descendant</title>
+<link rel="help" href="https://github.com/WICG/view-transitions">
+<link rel="author" href="mailto:[email protected]">
+<link rel="match" href="named-element-with-fix-pos-child-ref.html">
+<script src="/common/reftest-wait.js"></script>
+<style>
+.target {
+  width: 100px;
+  height: 100px;
+  background: blue;
+  view-transition-name: target;
+}
+.child {
+  width: 100px;
+  height: 100px;
+  position: fixed;
+  top: 150px;
+  left: 150px;
+  background: grey;
+}
+
+html::view-transition-group(target) { animation-duration: 300s; }
+html::view-transition-new(target) { animation: unset; opacity: 0; }
+html::view-transition-old(target) {
+  animation: unset;
+  opacity: 1;
+}
+</style>
+
+<div class=target>
+  <div class=child></div>
+</div>
+
+<script>
+failIfNot(document.startViewTransition, "Missing document.startViewTransition");
+
+async function runTest() {
+  document.startViewTransition(() =>
+    requestAnimationFrame(() => requestAnimationFrame(takeScreenshot)));
+}
+onload = () => requestAnimationFrame(() => requestAnimationFrame(runTest));
+</script>
+

third_party/blink/web_tests/external/wpt/css/css-view-transitions/named-element-with-fix-pos-child-ref.html

@@ -0,0 +1,26 @@
+<!DOCTYPE html>
+<html>
+<title>View transitions: element with fixed position descendant (ref)</title>
+<link rel="help" href="https://github.com/WICG/view-transitions">
+<link rel="author" href="mailto:[email protected]">
+<style>
+.target {
+  width: 100px;
+  height: 100px;
+  background: blue;
+  view-transition-name: target;
+}
+.child {
+  width: 100px;
+  height: 100px;
+  position: fixed;
+  top: 150px;
+  left: 150px;
+  background: grey;
+}
+</style>
+
+<div class=target>
+  <div class=child></div>
+</div>
+

third_party/blink/web_tests/external/wpt/css/css-view-transitions/new-content-element-writing-modes.html

@@ -27,9 +27,6 @@
   contain: paint;
   border: 1px solid black;
 }
-.source {
-  contain: layout;
-}
 #target {
   background: red;
   position: absolute;

third_party/blink/web_tests/external/wpt/css/css-view-transitions/new-content-object-fit-fill.html

@@ -29,7 +29,6 @@
   width: 10px;
   height: 10px;
   view-transition-name: hidden;
-  contain: layout;
 }
 
 html::view-transition-group(target) {

third_party/blink/web_tests/external/wpt/css/css-view-transitions/new-content-object-fit-none.html

@@ -21,7 +21,6 @@
   width: 10px;
   height: 10px;
   view-transition-name: hidden;
-  contain: layout;
 }
 
 html::view-transition-group(target) {