Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: claudiodekker/laravel-auth
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.1.1
Choose a base ref
...
head repository: claudiodekker/laravel-auth
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.1.2
Choose a head ref
  • 5 commits
  • 8 files changed
  • 1 contributor

Commits on Nov 30, 2022

  1. Copy the full SHA
    73f12b2 View commit details
  2. Add Laravel Pint linting to scaffolding-created files (#1)

    This PR adds Laravel pint to lint the template-generated authentication scaffolding.
    This is useful, as the templates themselves contain blade-conditionals, and aren't really lintable by default.
    claudiodekker authored Nov 30, 2022
    Copy the full SHA
    bb94432 View commit details
  3. Copy the full SHA
    e7ee48b View commit details
  4. Update CHANGELOG.md

    claudiodekker authored Nov 30, 2022
    Copy the full SHA
    b74f3ec View commit details

Commits on Dec 19, 2022

  1. Fix README.md shields

    claudiodekker authored Dec 19, 2022
    Copy the full SHA
    e2f75de View commit details
6 changes: 3 additions & 3 deletions packages/bladebones/.github/workflows/fix-styling.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: Check & fix styling

on: [push]
on: push

jobs:
laravel-pint:
pint:
runs-on: ubuntu-latest

steps:
@@ -17,7 +17,7 @@ jobs:
tools: pint

- name: Run Laravel Pint
run: pint --preset psr12
run: pint --preset laravel

- name: Commit changes
uses: stefanzweifel/git-auto-commit-action@v4
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
name: Validate Generator Styling

on:
push:
pull_request:

jobs:
validator:
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
strategy:
fail-fast: true
matrix:
variants: [
'',
'--without-rate-limiting',
'--kind username-based',
'--kind username-based --without-rate-limiting'
]

name: Variant - ${{ matrix.variants }}
steps:
- name: Checkout code
uses: actions/checkout@v3
with:
path: ./package

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.1
extensions: dom, curl, libxml, mbstring, zip
ini-values: error_reporting=E_ALL
tools: composer:v2, pint
coverage: none

- name: Create Laravel Project
uses: nick-fields/retry@v2
with:
timeout_minutes: 5
max_attempts: 5
command: composer create-project laravel/laravel app "9.x" --remove-vcs --prefer-dist --no-interaction

- name: Install Package
run: |
composer config repositories.package path ../package
composer require claudiodekker/laravel-auth-bladebones
working-directory: ./app

- name: Generate Auth Scaffolding
run: php artisan auth:generate --yes ${{ matrix.variants }}
working-directory: ./app

- name: Stage all generated files
run: |
git config --global user.email "github@actions.test"
git config --global user.name "GitHub Actions"
git init .
git add .
git commit -m "Generated Auth Scaffolding"
working-directory: ./app

- name: Fix using Laravel Pint
run: pint --preset laravel
working-directory: ./app

- name: Show any to-be-fixed changes
run: |
if [[ -z $(git status --porcelain) ]]; then
exit 0
fi
git -c color.ui=always --no-pager diff
exit 1
working-directory: ./app
7 changes: 7 additions & 0 deletions packages/bladebones/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased](https://github.com/claudiodekker/laravel-auth-bladebones/compare/v0.1.1...HEAD)

## [v0.1.2](https://github.com/claudiodekker/laravel-auth-bladebones/compare/v0.1.2...v0.1.1) - 2022-11-30

### Fixed

- Add Laravel Pint linting to scaffolding-created files ([#1](https://github.com/claudiodekker/laravel-auth-bladebones/pull/1))
- Fix imports on generated files ([#2](https://github.com/claudiodekker/laravel-auth-bladebones/pull/2))

## [v0.1.1](https://github.com/claudiodekker/laravel-auth-bladebones/compare/v0.1.1...v0.1.0) - 2022-11-30

### Fixed
11 changes: 6 additions & 5 deletions packages/bladebones/README.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
# Laravel Auth (for Blade; barebones edition)
Rich authentication scaffolding for any blade-based Laravel application.

[![Latest Version on Packagist](https://img.shields.io/packagist/v/claudiodekker/laravel-auth-bladebones.svg?style=flat-square)](https://packagist.org/packages/claudiodekker/laravel-auth-bladebones)
[![GitHub Tests Action Status](https://img.shields.io/github/workflow/status/claudiodekker/laravel-auth-bladebones/run-tests?label=tests)](https://github.com/claudiodekker/laravel-auth-bladebones/actions?query=workflow%3Arun-tests+branch%3Amaster)
[![GitHub Code Style Action Status](https://img.shields.io/github/workflow/status/claudiodekker/laravel-auth-bladebones/Check%20&%20fix%20styling?label=code%20style)](https://github.com/claudiodekker/laravel-auth-bladebones/actions?query=workflow%3A"Check+%26+fix+styling"+branch%3Amaster)
[![Code Quality Score](https://img.shields.io/scrutinizer/g/claudiodekker/laravel-auth-bladebones.svg?style=flat-square)](https://scrutinizer-ci.com/g/claudiodekker/laravel-auth-bladebones)
[![Total Downloads](https://img.shields.io/packagist/dt/claudiodekker/laravel-auth-bladebones.svg?style=flat-square)](https://packagist.org/packages/claudiodekker/laravel-auth-bladebones)
[![Latest Version on Packagist](https://img.shields.io/packagist/v/claudiodekker/laravel-auth-bladebones.svg)](https://packagist.org/packages/claudiodekker/laravel-auth-bladebones)
[![GitHub App Tests Action Status](https://github.com/claudiodekker/laravel-auth-bladebones/actions/workflows/app-tests.yml/badge.svg)](https://github.com/claudiodekker/laravel-auth-bladebones/actions/workflows/app-tests.yml)
[![Github Package Tests Action Status](https://github.com/claudiodekker/laravel-auth-bladebones/actions/workflows/package-tests.yml/badge.svg)](https://github.com/claudiodekker/laravel-auth-bladebones/actions/workflows/package-tests.yml)
[![GitHub Code Style Action Status](https://img.shields.io/github/actions/workflow/status/claudiodekker/laravel-auth-bladebones/fix-styling.yml?label=code%20style&logo=github&branch=master)](https://github.com/claudiodekker/laravel-auth-bladebones/actions?query=workflow%3A"Check+%26+fix+styling"+branch%3Amaster)
[![Code Quality Score](https://img.shields.io/scrutinizer/g/claudiodekker/laravel-auth-bladebones.svg?logo=scrutinizer)](https://scrutinizer-ci.com/g/claudiodekker/laravel-auth-bladebones)
[![Total Downloads](https://img.shields.io/packagist/dt/claudiodekker/laravel-auth-bladebones.svg)](https://packagist.org/packages/claudiodekker/laravel-auth-bladebones)

These days, most (web)applications no longer have just a simple username-password login form; they require you to think about password strength, two-factor authentication,
the ability to recover your account with all of this set up, and as of more recently even the ability to log in without any password at all, using Passkeys.
1 change: 0 additions & 1 deletion packages/bladebones/stubs/defaults/routes/web.stub
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?php

use App\Http\Controllers\Auth\AccountRecoveryController;
use App\Http\Controllers\Auth\AccountRecoveryRequestController;
use App\Http\Controllers\Auth\Challenges\AccountRecoveryChallengeController;
use App\Http\Controllers\Auth\Challenges\MultiFactorChallengeController;
Original file line number Diff line number Diff line change
@@ -29,7 +29,9 @@ use Illuminate\Contracts\Auth\Authenticatable;
use Illuminate\Contracts\View\View;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
@if (!$withoutRateLimiting)
use Illuminate\Validation\ValidationException;
@endif

class AccountRecoveryRequestController extends BaseController
{
Original file line number Diff line number Diff line change
@@ -5,11 +5,11 @@
@endphp
namespace Tests\Feature;

use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryRequestTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerification\{{ $verificationTrait }};
use ClaudioDekker\LaravelAuth\Testing\EmailVerificationTests;
use ClaudioDekker\LaravelAuth\Testing\Flavors\{{ $flavorTrait }};
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\GenerateRecoveryCodesTests;
use ClaudioDekker\LaravelAuth\Testing\LoginTests;
use ClaudioDekker\LaravelAuth\Testing\LogoutTests;
Original file line number Diff line number Diff line change
@@ -71,11 +71,11 @@ public function it_accepts_all_default_options_without_prompting_when_passing_th
namespace Tests\Feature;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryRequestTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerification\RegisterWithVerificationEmailTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerificationTests;
use ClaudioDekker\LaravelAuth\Testing\Flavors\EmailBased;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\GenerateRecoveryCodesTests;
use ClaudioDekker\LaravelAuth\Testing\LoginTests;
use ClaudioDekker\LaravelAuth\Testing\LogoutTests;
@@ -169,11 +169,11 @@ public function it_asks_whether_you_want_to_use_rate_limiting(): void
namespace Tests\Feature;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryRequestTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerification\RegisterWithoutVerificationEmailTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerificationTests;
use ClaudioDekker\LaravelAuth\Testing\Flavors\EmailBased;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\GenerateRecoveryCodesTests;
use ClaudioDekker\LaravelAuth\Testing\LoginTests;
use ClaudioDekker\LaravelAuth\Testing\LogoutTests;
@@ -255,11 +255,11 @@ public function it_disables_rate_limiting_when_you_answer_the_rate_limiting_ques
namespace Tests\Feature;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryRequestTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerification\RegisterWithoutVerificationEmailTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerificationTests;
use ClaudioDekker\LaravelAuth\Testing\Flavors\EmailBased;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\GenerateRecoveryCodesTests;
use ClaudioDekker\LaravelAuth\Testing\LoginTests;
use ClaudioDekker\LaravelAuth\Testing\LogoutTests;
@@ -340,11 +340,11 @@ public function it_disables_rate_limiting_when_the_without_rate_limiting_flag_wa
namespace Tests\Feature;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryRequestTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerification\RegisterWithVerificationEmailTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerificationTests;
use ClaudioDekker\LaravelAuth\Testing\Flavors\EmailBased;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\GenerateRecoveryCodesTests;
use ClaudioDekker\LaravelAuth\Testing\LoginTests;
use ClaudioDekker\LaravelAuth\Testing\LogoutTests;
@@ -426,11 +426,11 @@ public function it_asks_whether_you_want_to_send_verification_emails_on_registra
namespace Tests\Feature;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryRequestTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerification\RegisterWithVerificationEmailTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerificationTests;
use ClaudioDekker\LaravelAuth\Testing\Flavors\EmailBased;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\GenerateRecoveryCodesTests;
use ClaudioDekker\LaravelAuth\Testing\LoginTests;
use ClaudioDekker\LaravelAuth\Testing\LogoutTests;
@@ -512,11 +512,11 @@ public function it_does_not_send_verification_emails_on_registration_when_you_an
namespace Tests\Feature;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryRequestTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerification\RegisterWithoutVerificationEmailTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerificationTests;
use ClaudioDekker\LaravelAuth\Testing\Flavors\EmailBased;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\GenerateRecoveryCodesTests;
use ClaudioDekker\LaravelAuth\Testing\LoginTests;
use ClaudioDekker\LaravelAuth\Testing\LogoutTests;
@@ -597,11 +597,11 @@ public function it_does_not_send_verification_emails_on_registration_when_the_re
namespace Tests\Feature;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryRequestTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerification\RegisterWithoutVerificationEmailTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerificationTests;
use ClaudioDekker\LaravelAuth\Testing\Flavors\EmailBased;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\GenerateRecoveryCodesTests;
use ClaudioDekker\LaravelAuth\Testing\LoginTests;
use ClaudioDekker\LaravelAuth\Testing\LogoutTests;
@@ -683,11 +683,11 @@ public function it_does_not_create_views_and_view_tests_when_the_without_views_f
namespace Tests\Feature;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryRequestTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerification\RegisterWithVerificationEmailTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerificationTests;
use ClaudioDekker\LaravelAuth\Testing\Flavors\EmailBased;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\GenerateRecoveryCodesTests;
use ClaudioDekker\LaravelAuth\Testing\LoginTests;
use ClaudioDekker\LaravelAuth\Testing\LogoutTests;
@@ -784,11 +784,11 @@ public function it_asks_what_flavor_of_user_accounts_should_be_used(): void
namespace Tests\Feature;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryRequestTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerification\RegisterWithoutVerificationEmailTests;
use ClaudioDekker\LaravelAuth\Testing\EmailVerificationTests;
use ClaudioDekker\LaravelAuth\Testing\Flavors\UsernameBased;
use ClaudioDekker\LaravelAuth\Testing\AccountRecoveryChallengeTests;
use ClaudioDekker\LaravelAuth\Testing\GenerateRecoveryCodesTests;
use ClaudioDekker\LaravelAuth\Testing\LoginTests;
use ClaudioDekker\LaravelAuth\Testing\LogoutTests;