Fix datetime type #374
Merged
Fix datetime type #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As defined by the jquery ui datepicker documentation, "yy" referes to the four digit year.
The datetime picker expects and produces dates / time pairs separated by the "T" character, not a space. Further, it does not handle seconds at all. Therefore, we have to provide the timestamp in the input field separated by a "T" and for consistency drop seconds altogether. Hence, it becomes necessary to replace the "T" by a space again before providing it to jQuery date picker fallback. Further, we have to actually parse the "T" when validating the timestamps we receive from the user.
input type datetime-local does not support seconds and therefore neither does this type anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the datetime type is broken in virtually every single browser in one way or another. Also, the jQuery date picker is broken in browsers which do not support the input type
date. This has been caused by #363.This pull request resolves these multiple issues.
let's test it before merging:
This fixes #373