Fix HTTPS cache problems on pages with certificate errors

[GoogleCodeExporter]

This is an optional fix. By default Chromium disables caching when there is certificate error. This patch will fix the HTTPS caching only when ApplicationSettings "ignore_certificate_errors" is set to True.

See http://www.magpcss.org/ceforum/viewtopic.php?f=6&t=11609

The patch suggested in the linked topic works fine after making some minor
changes.

Index: net/http/http_cache_transaction.cc
===================================================================
--- http_cache_transaction.cc   (revision 241641)
+++ http_cache_transaction.cc   (working copy)
@@ -2240,7 +2240,8 @@
   // reverse-map the cert status to a net error and replay the net error.
   if ((cache_->mode() != RECORD &&
        response_.headers->HasHeaderValue("cache-control", "no-store")) ||
-      net::IsCertStatusError(response_.ssl_info.cert_status)) {
+       (!cache_->GetSession()->params().ignore_certificate_errors &&
+       net::IsCertStatusError(response_.ssl_info.cert_status))) {
     DoneWritingToEntry(false);
     ReportCacheActionFinish();
     if (net_log_.IsLoggingAllEvents())

The patch was verified to work with CEF 3 branch 1650 revision 1646. The https
web server was nginx running on Ubuntu.

Patch instructions available here (both BuildOnLinux and BuildOnWindows wiki pages).

Original issue reported on code.google.com by czarek.t...@gmail.com on 27 May 2014 at 8:38

[cztomczak]

This patch is currently disabled in v55 on Windows/Mac. Only Linux has this applied.