Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dart-archive/file.dart
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e90e5ed
Choose a base ref
...
head repository: dart-archive/file.dart
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f05f5db
Choose a head ref
  • 4 commits
  • 8 files changed
  • 3 contributors

Commits on May 12, 2023

  1. Make FileSystem.isLink actually work (#214)

    * Make `FileSystem.isLink` actually work
    
    `FileSystem.isLink` called `FileSystem.type` with the default
    argument of `followLinks: true`.  This is obviously wrong since it
    would mean that `isLink` would never return true (except maybe for
    broken symbolic links).
    
    Make `FileSystem.isLink` use `followLinks: false`.  This is what
    `dart:io`'s `FileSystemEntity.isLink` is documented to do.
    
    Partially addresses https://github.com/google/file.dart/issues/8.
    
    * Reorganize isFile/isDirectory/isLink tests
    
    Reorganize the isFile/isDirectory/isLink tests so that the test names
    are more appropriate.
    jamesderlin authored May 12, 2023
    Configuration menu
    Copy the full SHA
    7941466 View commit details
    Browse the repository at this point in the history
  2. Fix MemoryFileSystem to treat an empty path as non-existent (#213)

    * Fix MemoryFileSystem to treat an empty path as non-existent
    
    `_MemoryFileSystem.findNode` returns `reference?.directory` if given
    the root path or an empty path.  However, an empty path should
    be treated as non-existent, not as a directory.  Instead explicitly
    return `null` as a special case when given an empty path.
    
    Partially addresses https://github.com/google/file.dart/issues/198.
    
    * Make _MemoryFileSystem._current nullable
    jamesderlin authored May 12, 2023
    Configuration menu
    Copy the full SHA
    5e76f74 View commit details
    Browse the repository at this point in the history
  3. MemoryFileSystem addStream onError (#220)

    Route stream errors to the stream completer rather than the file completer.
    
    Fixes #219
    AsturaPhoenix authored May 12, 2023
    Configuration menu
    Copy the full SHA
    f2f3076 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Make MemoryFile.openRead and _ChrootFile.openRead return Stream<List<…

    …int>> again (#217)
    
    * Make MemoryFile.openRead and _ChrootFile.openRead return Stream<List<int>> again
    
    This is equivalent to #168,
    but I foolishly neglected to make corresponding changes for all
    file system types.
    
    Fixes https://github.com/google/file.dart/issues/193.
    
    * Apply suggestions from natebosch
    
    Co-authored-by: Nate Bosch <[email protected]>
    
    ---------
    
    Co-authored-by: Nate Bosch <[email protected]>
    jamesderlin and natebosch authored May 15, 2023
    Configuration menu
    Copy the full SHA
    f05f5db View commit details
    Browse the repository at this point in the history
Loading