Skip to content

No error if passing a VM service URI instead of a DTD uri #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakemac53 opened this issue Apr 15, 2025 · 4 comments
Open

No error if passing a VM service URI instead of a DTD uri #67

jakemac53 opened this issue Apr 15, 2025 · 4 comments

Comments

@jakemac53
Copy link
Contributor

See thread here #66 (comment).

It seems like the connect to DTD tool will return success even if it ends up connecting to a VM service instead of a DTD service.

@jakemac53
Copy link
Contributor Author

@kenzieschmoll any ideas how we might do this?

There is no real handshake or anything upon connection at the moment and adding a required one would be breaking...

@kenzieschmoll kenzieschmoll added the dart_tooling_mcp_server: dtd tools Issues related to DTD MCP server tools label Apr 23, 2025
@sigurdm
Copy link

sigurdm commented May 2, 2025

Could the vm service uri somehow be used to produce a dtd uri, so things end up working?

@jakemac53
Copy link
Contributor Author

jakemac53 commented May 2, 2025

We might be able to just gracefully handle being given either a DTD Uri or a VM service URI. Ultimately right now we only really need the VM service URI (but in the IDE, its easier to get a DTD Uri).

I think maybe we should just get some sort of entry point implemented by each of the services which just allows it to identify itself?

Basically we would then first connect assuming it was DTD, and then ask if its actually DTD, and if not reconnect assuming it is the VM service (or possibly hand off the existing connection).

@jakemac53
Copy link
Contributor Author

cc @bkonyi thoughts on some sort of "identity" request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants