[analyzer] Dot Shorthands: Add DotShorthandConstructorInvocation AST and resolve constructors.

When we resolve a DotShorthandInvocation, it can either be a method invocation or a constructor invocation. This CL adds a `DotShorthandConstructorInvocation` node to represent the shorthand equivalent of an `InstanceCreationExpression` (without the extra bulk of needing a synthetic `NamedType`), and adds the resolution logic.

Test added in the form of unit test and existing language tests.

Bug: #59835
Change-Id: I6966ce549f2b079efc0b002fba41bc31a90871c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422544
Reviewed-by: Paul Berry <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

pkg/analyzer/api.txt

@@ -373,6 +373,7 @@ package:analyzer/dart/ast/ast.dart:
     visitDeclaredVariablePattern (method: R? Function(DeclaredVariablePattern))
     visitDefaultFormalParameter (method: R? Function(DefaultFormalParameter))
     visitDoStatement (method: R? Function(DoStatement))
+    visitDotShorthandConstructorInvocation (method: R? Function(DotShorthandConstructorInvocation))
     visitDotShorthandInvocation (method: R? Function(DotShorthandInvocation))
     visitDotShorthandPropertyAccess (method: R? Function(DotShorthandPropertyAccess))
     visitDottedName (method: R? Function(DottedName))
@@ -715,6 +716,9 @@ package:analyzer/dart/ast/ast.dart:
     rightParenthesis (getter: Token)
     semicolon (getter: Token)
     whileKeyword (getter: Token)
+  DotShorthandConstructorInvocation (class extends InvocationExpression implements ConstructorReferenceNode, experimental):
+    constructorName (getter: SimpleIdentifier)
+    period (getter: Token)
   DotShorthandInvocation (class extends InvocationExpression, experimental):
     memberName (getter: SimpleIdentifier)
     period (getter: Token)
@@ -1897,6 +1901,7 @@ package:analyzer/dart/ast/visitor.dart:
     visitDefaultFormalParameter (method: R? Function(DefaultFormalParameter))
     visitDirective (method: R? Function(Directive))
     visitDoStatement (method: R? Function(DoStatement))
+    visitDotShorthandConstructorInvocation (method: R? Function(DotShorthandConstructorInvocation))
     visitDotShorthandInvocation (method: R? Function(DotShorthandInvocation))
     visitDotShorthandPropertyAccess (method: R? Function(DotShorthandPropertyAccess))
     visitDottedName (method: R? Function(DottedName))
@@ -2095,6 +2100,7 @@ package:analyzer/dart/ast/visitor.dart:
     visitDeclaredVariablePattern (method: R? Function(DeclaredVariablePattern))
     visitDefaultFormalParameter (method: R? Function(DefaultFormalParameter))
     visitDoStatement (method: R? Function(DoStatement))
+    visitDotShorthandConstructorInvocation (method: R? Function(DotShorthandConstructorInvocation))
     visitDotShorthandInvocation (method: R? Function(DotShorthandInvocation))
     visitDotShorthandPropertyAccess (method: R? Function(DotShorthandPropertyAccess))
     visitDottedName (method: R? Function(DottedName))
@@ -2271,6 +2277,7 @@ package:analyzer/dart/ast/visitor.dart:
     visitDeclaredVariablePattern (method: R? Function(DeclaredVariablePattern))
     visitDefaultFormalParameter (method: R? Function(DefaultFormalParameter))
     visitDoStatement (method: R? Function(DoStatement))
+    visitDotShorthandConstructorInvocation (method: R? Function(DotShorthandConstructorInvocation))
     visitDotShorthandInvocation (method: R? Function(DotShorthandInvocation))
     visitDotShorthandPropertyAccess (method: R? Function(DotShorthandPropertyAccess))
     visitDottedName (method: R? Function(DottedName))
@@ -2447,6 +2454,7 @@ package:analyzer/dart/ast/visitor.dart:
     visitDeclaredVariablePattern (method: R? Function(DeclaredVariablePattern))
     visitDefaultFormalParameter (method: R? Function(DefaultFormalParameter))
     visitDoStatement (method: R? Function(DoStatement))
+    visitDotShorthandConstructorInvocation (method: R? Function(DotShorthandConstructorInvocation))
     visitDotShorthandInvocation (method: R? Function(DotShorthandInvocation))
     visitDotShorthandPropertyAccess (method: R? Function(DotShorthandPropertyAccess))
     visitDottedName (method: R? Function(DottedName))
@@ -2624,6 +2632,7 @@ package:analyzer/dart/ast/visitor.dart:
     visitDeclaredVariablePattern (method: T? Function(DeclaredVariablePattern))
     visitDefaultFormalParameter (method: T? Function(DefaultFormalParameter))
     visitDoStatement (method: T? Function(DoStatement))
+    visitDotShorthandConstructorInvocation (method: T? Function(DotShorthandConstructorInvocation))
     visitDotShorthandInvocation (method: T? Function(DotShorthandInvocation))
     visitDotShorthandPropertyAccess (method: T? Function(DotShorthandPropertyAccess))
     visitDottedName (method: T? Function(DottedName))
@@ -2800,6 +2809,7 @@ package:analyzer/dart/ast/visitor.dart:
     visitDeclaredVariablePattern (method: R? Function(DeclaredVariablePattern))
     visitDefaultFormalParameter (method: R? Function(DefaultFormalParameter))
     visitDoStatement (method: R? Function(DoStatement))
+    visitDotShorthandConstructorInvocation (method: R? Function(DotShorthandConstructorInvocation))
     visitDotShorthandInvocation (method: R? Function(DotShorthandInvocation))
     visitDotShorthandPropertyAccess (method: R? Function(DotShorthandPropertyAccess))
     visitDottedName (method: R? Function(DottedName))

pkg/analyzer/lib/dart/ast/ast.dart

@@ -93,6 +93,7 @@ export 'package:analyzer/src/dart/ast/ast.dart'
         Directive,
         DoStatement,
         DotShorthandInvocation,
+        DotShorthandConstructorInvocation,
         DotShorthandPropertyAccess,
         DottedName,
         DoubleLiteral,

pkg/analyzer/lib/dart/ast/visitor.dart

@@ -279,6 +279,11 @@ class GeneralizingAstVisitor<R> implements AstVisitor<R> {
   @override
   R? visitDoStatement(DoStatement node) => visitStatement(node);
 
+  @override
+  R? visitDotShorthandConstructorInvocation(
+          DotShorthandConstructorInvocation node) =>
+      visitExpression(node);
+
   @override
   R? visitDotShorthandInvocation(DotShorthandInvocation node) =>
       visitExpression(node);
@@ -1043,6 +1048,13 @@ class RecursiveAstVisitor<R> implements AstVisitor<R> {
     return null;
   }
 
+  @override
+  R? visitDotShorthandConstructorInvocation(
+      DotShorthandConstructorInvocation node) {
+    node.visitChildren(this);
+    return null;
+  }
+
   @override
   R? visitDotShorthandInvocation(DotShorthandInvocation node) {
     node.visitChildren(this);
@@ -1985,6 +1997,11 @@ class SimpleAstVisitor<R> implements AstVisitor<R> {
   @override
   R? visitDoStatement(DoStatement node) => null;
 
+  @override
+  R? visitDotShorthandConstructorInvocation(
+          DotShorthandConstructorInvocation node) =>
+      null;
+
   @override
   R? visitDotShorthandInvocation(DotShorthandInvocation node) => null;
 
@@ -2534,6 +2551,11 @@ class ThrowingAstVisitor<R> implements AstVisitor<R> {
   @override
   R? visitDoStatement(DoStatement node) => _throw(node);
 
+  @override
+  R? visitDotShorthandConstructorInvocation(
+          DotShorthandConstructorInvocation node) =>
+      _throw(node);
+
   @override
   R? visitDotShorthandInvocation(DotShorthandInvocation node) => _throw(node);
 
@@ -3299,6 +3321,15 @@ class TimedAstVisitor<T> implements AstVisitor<T> {
     return result;
   }
 
+  @override
+  T? visitDotShorthandConstructorInvocation(
+      DotShorthandConstructorInvocation node) {
+    stopwatch.start();
+    T? result = _baseVisitor.visitDotShorthandConstructorInvocation(node);
+    stopwatch.stop();
+    return result;
+  }
+
   @override
   T? visitDotShorthandInvocation(DotShorthandInvocation node) {
     stopwatch.start();
@@ -4521,6 +4552,11 @@ class UnifyingAstVisitor<R> implements AstVisitor<R> {
   @override
   R? visitDoStatement(DoStatement node) => visitNode(node);
 
+  @override
+  R? visitDotShorthandConstructorInvocation(
+          DotShorthandConstructorInvocation node) =>
+      visitNode(node);
+
   @override
   R? visitDotShorthandInvocation(DotShorthandInvocation node) =>
       visitNode(node);

pkg/analyzer/lib/src/dart/ast/ast.dart

@@ -1233,6 +1233,9 @@ abstract class AstVisitor<R> {
 
   R? visitDoStatement(DoStatement node);
 
+  R? visitDotShorthandConstructorInvocation(
+      DotShorthandConstructorInvocation node);
+
   R? visitDotShorthandInvocation(DotShorthandInvocation node);
 
   R? visitDotShorthandPropertyAccess(DotShorthandPropertyAccess node);
@@ -5192,6 +5195,91 @@ final class DoStatementImpl extends StatementImpl implements DoStatement {
   }
 }
 
+/// A node that represents a dot shorthand constructor invocation.
+///
+/// For example, `.fromCharCode(42)`.
+///
+///    dotShorthandHead ::=
+///        '.' [SimpleIdentifier] [TypeArgumentList]? [ArgumentList]
+@experimental
+@AnalyzerPublicApi(message: 'exported by lib/dart/ast/ast.dart')
+abstract final class DotShorthandConstructorInvocation
+    extends InvocationExpression implements ConstructorReferenceNode {
+  /// The name of the constructor invocation.
+  SimpleIdentifier get constructorName;
+
+  /// The token representing the period.
+  Token get period;
+}
+
+final class DotShorthandConstructorInvocationImpl
+    extends InvocationExpressionImpl
+    implements
+        DotShorthandConstructorInvocation,
+        RewrittenMethodInvocationImpl {
+  @override
+  final Token period;
+
+  SimpleIdentifierImpl _constructorName;
+
+  @override
+  ConstructorElementImpl2? element;
+
+  /// Initializes a newly created dot shorthand constructor invocation.
+  DotShorthandConstructorInvocationImpl({
+    required this.period,
+    required SimpleIdentifierImpl constructorName,
+    required super.typeArguments,
+    required super.argumentList,
+  }) : _constructorName = constructorName {
+    _becomeParentOf(_constructorName);
+  }
+
+  @override
+  Token get beginToken => period;
+
+  @override
+  SimpleIdentifierImpl get constructorName => _constructorName;
+
+  set constructorName(SimpleIdentifierImpl identifier) {
+    _constructorName = _becomeParentOf(identifier);
+  }
+
+  @override
+  Token get endToken => argumentList.endToken;
+
+  @override
+  ExpressionImpl get function => constructorName;
+
+  @override
+  Precedence get precedence => Precedence.postfix;
+
+  @override
+  ChildEntities get _childEntities => ChildEntities()
+    ..addToken('period', period)
+    ..addNode('constructorName', constructorName)
+    ..addNode('typeArguments', typeArguments)
+    ..addNode('argumentList', argumentList);
+
+  @override
+  E? accept<E>(AstVisitor<E> visitor) =>
+      visitor.visitDotShorthandConstructorInvocation(this);
+
+  @override
+  void resolveExpression(ResolverVisitor resolver, TypeImpl contextType) {
+    throw StateError(
+        'DotShorthandConstructorInvocationImpl should only appear in fully'
+        ' resolved ASTs');
+  }
+
+  @override
+  void visitChildren(AstVisitor visitor) {
+    constructorName.accept(visitor);
+    typeArguments?.accept(visitor);
+    argumentList.accept(visitor);
+  }
+}
+
 /// A node that represents a dot shorthand static method or constructor
 /// invocation.
 ///
@@ -8488,7 +8576,7 @@ abstract final class FunctionExpressionInvocation
 
 final class FunctionExpressionInvocationImpl extends InvocationExpressionImpl
     with NullShortableExpressionImpl
-    implements FunctionExpressionInvocation {
+    implements FunctionExpressionInvocation, RewrittenMethodInvocationImpl {
   ExpressionImpl _function;
 
   @override
@@ -10562,8 +10650,8 @@ final class InterpolationStringImpl extends InterpolationElementImpl
 
 /// The invocation of a function or method.
 ///
-/// This will either be a [FunctionExpressionInvocation], [MethodInvocation],
-/// or a [DotShorthandInvocation].
+/// This will either be a [FunctionExpressionInvocation], a [MethodInvocation],
+/// a [DotShorthandConstructorInvocation], or a [DotShorthandInvocation].
 @AnalyzerPublicApi(message: 'exported by lib/dart/ast/ast.dart')
 abstract final class InvocationExpression implements Expression {
   /// The list of arguments to the method.
@@ -15345,6 +15433,12 @@ final class ReturnStatementImpl extends StatementImpl
   }
 }
 
+/// A resolved dot shorthand invocation.
+///
+/// Either a [FunctionExpressionInvocationImpl], a static method invocation, or
+/// a [DotShorthandConstructorInvocationImpl], a constructor invocation.
+sealed class RewrittenMethodInvocationImpl implements ExpressionImpl {}
+
 /// A script tag that can optionally occur at the beginning of a compilation
 /// unit.
 ///

pkg/analyzer/lib/src/dart/ast/to_source_visitor.dart

@@ -348,6 +348,15 @@ class ToSourceVisitor implements AstVisitor<void> {
     sink.write(');');
   }
 
+  @override
+  void visitDotShorthandConstructorInvocation(
+      DotShorthandConstructorInvocation node) {
+    _visitToken(node.period);
+    _visitNode(node.constructorName);
+    _visitNode(node.typeArguments);
+    _visitNode(node.argumentList);
+  }
+
   @override
   void visitDotShorthandInvocation(DotShorthandInvocation node) {
     _visitToken(node.period);

pkg/analyzer/lib/src/dart/resolver/constructor_reference_resolver.dart

@@ -91,7 +91,8 @@ class ConstructorReferenceResolver {
       {required DartType contextType}) {
     var constructorName = node.constructorName;
     var elementToInfer = _resolver.inferenceHelper.constructorElementToInfer(
-      constructorName: constructorName,
+      typeElement: constructorName.type.element2,
+      constructorName: constructorName.name,
       definingLibrary: _resolver.definingLibrary,
     );
 

pkg/analyzer/lib/src/dart/resolver/instance_creation_expression_resolver.dart

@@ -7,7 +7,8 @@ import 'package:analyzer/src/dart/element/type.dart';
 import 'package:analyzer/src/dart/resolver/invocation_inferrer.dart';
 import 'package:analyzer/src/generated/resolver.dart';
 
-/// A resolver for [InstanceCreationExpression] nodes.
+/// A resolver for [InstanceCreationExpression] and
+/// [DotShorthandConstructorInvocation] nodes.
 ///
 /// This resolver is responsible for rewriting a given
 /// [InstanceCreationExpression] as a [MethodInvocation] if the parsed
@@ -49,6 +50,48 @@ class InstanceCreationExpressionResolver {
     _resolveInstanceCreationExpression(node, contextType: contextType);
   }
 
+  /// Resolves a [DotShorthandConstructorInvocation] node.
+  void resolveDotShorthand(DotShorthandConstructorInvocationImpl node) {
+    TypeImpl contextType =
+        _resolver.getDotShorthandContext().unwrapTypeSchemaView();
+
+    // The static namespace denoted by `S` is also the namespace denoted by
+    // `FutureOr<S>`.
+    contextType = _resolver.typeSystem.futureOrBase(contextType);
+
+    // TODO(kallentu): Support other context types
+    if (contextType is InterfaceTypeImpl) {
+      _resolveDotShorthandConstructorInvocation(node, contextType: contextType);
+    }
+
+    // TODO(kallentu): Report error.
+  }
+
+  void _resolveDotShorthandConstructorInvocation(
+      DotShorthandConstructorInvocationImpl node,
+      {required TypeImpl contextType}) {
+    var whyNotPromotedArguments = <WhyNotPromotedGetter>[];
+    _resolver.elementResolver.visitDotShorthandConstructorInvocation(node);
+    var elementToInfer = _resolver.inferenceHelper.constructorElementToInfer(
+      typeElement: contextType.element3,
+      constructorName: node.constructorName,
+      definingLibrary: _resolver.definingLibrary,
+    );
+    DotShorthandConstructorInvocationInferrer(
+            resolver: _resolver,
+            node: node,
+            argumentList: node.argumentList,
+            contextType: contextType,
+            whyNotPromotedArguments: whyNotPromotedArguments)
+        .resolveInvocation(
+            // TODO(paulberry): eliminate this cast by changing the type of
+            // `ConstructorElementToInfer.asType`.
+            rawType: elementToInfer?.asType as FunctionTypeImpl?);
+    node.recordStaticType(contextType, resolver: _resolver);
+    _resolver.checkForArgumentTypesNotAssignableInList(
+        node.argumentList, whyNotPromotedArguments);
+  }
+
   void _resolveInstanceCreationExpression(InstanceCreationExpressionImpl node,
       {required TypeImpl contextType}) {
     var whyNotPromotedArguments = <WhyNotPromotedGetter>[];
@@ -58,7 +101,8 @@ class InstanceCreationExpressionResolver {
     constructorName = node.constructorName;
     _resolver.elementResolver.visitInstanceCreationExpression(node);
     var elementToInfer = _resolver.inferenceHelper.constructorElementToInfer(
-      constructorName: constructorName,
+      typeElement: constructorName.type.element2,
+      constructorName: node.constructorName.name,
       definingLibrary: _resolver.definingLibrary,
     );
     InstanceCreationInferrer(