Skip to content

Commit eba91c5

Browse files
srawlinsCommit Queue
authored and
Commit Queue
committed
analyzer: Move RuleState into the public API
Work towards #50986 Change-Id: I32e1d9b6dbb0a6ef91569ae65100365f775ec0f9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/430544 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Samuel Rawlins <[email protected]>
1 parent 34c5794 commit eba91c5

File tree

5 files changed

+22
-8
lines changed

5 files changed

+22
-8
lines changed

pkg/analysis_server/test/src/services/correction/fix/analysis_options/test_support.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44

55
import 'package:analysis_server/src/services/correction/fix/analysis_options/fix_generator.dart';
66
import 'package:analysis_server_plugin/edit/fix/fix.dart';
7+
import 'package:analyzer/analysis_rule/rule_state.dart';
78
import 'package:analyzer/diagnostic/diagnostic.dart';
89
import 'package:analyzer/source/file_source.dart';
910
import 'package:analyzer/src/generated/source.dart';
10-
import 'package:analyzer/src/lint/state.dart';
1111
import 'package:analyzer/src/task/options.dart';
1212
import 'package:analyzer_plugin/protocol/protocol_common.dart'
1313
hide AnalysisError;

pkg/analyzer/api.txt

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,20 @@
1+
package:analyzer/analysis_rule/rule_state.dart:
2+
dart2_12 (static getter: Version)
3+
dart3 (static getter: Version)
4+
dart3_3 (static getter: Version)
5+
RuleState (class extends Object):
6+
deprecated (constructor: RuleState Function({String? replacedBy, Version? since}))
7+
experimental (constructor: RuleState Function({Version? since}))
8+
internal (constructor: RuleState Function({Version? since}))
9+
removed (constructor: RuleState Function({String? replacedBy, Version? since}))
10+
stable (constructor: RuleState Function({Version? since}))
11+
isDeprecated (getter: bool)
12+
isExperimental (getter: bool)
13+
isInternal (getter: bool)
14+
isRemoved (getter: bool)
15+
label (getter: String)
16+
replacedBy (getter: String?)
17+
since (getter: Version?)
118
package:analyzer/dart/analysis/analysis_context.dart:
219
AnalysisContext@1 (class extends Object):
320
new (constructor: AnalysisContext@1 Function())

pkg/analyzer/lib/src/lint/state.dart renamed to pkg/analyzer/lib/analysis_rule/rule_state.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,6 @@ final Version dart3 = Version(3, 0, 0);
1313
/// A version describing Dart language version 3.3.0.
1414
final Version dart3_3 = Version(3, 3, 0);
1515

16-
@Deprecated("Prefer to use 'RuleState'")
17-
typedef State = RuleState;
18-
1916
/// Describes the state of an analysis rule.
2017
final class RuleState {
2118
/// An Optional Dart language version that identifies the start of this state.

pkg/analyzer/lib/src/lint/linter.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
import 'package:analyzer/analysis_rule/rule_state.dart';
56
import 'package:analyzer/dart/analysis/features.dart';
67
import 'package:analyzer/dart/analysis/results.dart';
78
import 'package:analyzer/dart/ast/ast.dart';
@@ -15,13 +16,12 @@ import 'package:analyzer/error/listener.dart';
1516
import 'package:analyzer/file_system/file_system.dart';
1617
import 'package:analyzer/src/lint/linter_visitor.dart' show RuleVisitorRegistry;
1718
import 'package:analyzer/src/lint/pub.dart';
18-
import 'package:analyzer/src/lint/state.dart';
1919
import 'package:analyzer/workspace/workspace.dart';
2020
import 'package:meta/meta.dart';
2121

22-
export 'package:analyzer/src/lint/linter_visitor.dart' show NodeLintRegistry;
23-
export 'package:analyzer/src/lint/state.dart'
22+
export 'package:analyzer/analysis_rule/rule_state.dart'
2423
show dart2_12, dart3, dart3_3, RuleState;
24+
export 'package:analyzer/src/lint/linter_visitor.dart' show NodeLintRegistry;
2525

2626
/// Describes an [AbstractAnalysisRule] which reports diagnostics using exactly
2727
/// one [DiagnosticCode].

pkg/linter/tool/messages_info.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
import 'package:analyzer/analysis_rule/rule_state.dart';
56
import 'package:analyzer/src/lint/io.dart';
6-
import 'package:analyzer/src/lint/state.dart';
77
import 'package:collection/collection.dart';
88
import 'package:pub_semver/pub_semver.dart';
99
import 'package:yaml/yaml.dart';

0 commit comments

Comments
 (0)