Skip to content

Reject package:js changes in a hot reload in DDC #60223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
srujzs opened this issue Feb 27, 2025 · 0 comments
Open

Reject package:js changes in a hot reload in DDC #60223

srujzs opened this issue Feb 27, 2025 · 0 comments
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop P2 A bug or feature request we're likely to work on web-dev-compiler web-hot-reload Issues related to stateful hot reload on the web

Comments

@srujzs
Copy link
Contributor

srujzs commented Feb 27, 2025

package:js class members may emit stubs at runtime to support virtual/dynamic dispatch and type-checks. Supporting different versions of these members as users make edits may prove to be difficult. Instead, we should reject changes to such members early to avoid undefined semantics.
@srujzs srujzs added area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop web-hot-reload Issues related to stateful hot reload on the web labels Feb 27, 2025
@nshahan nshahan added the P2 A bug or feature request we're likely to work on label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop P2 A bug or feature request we're likely to work on web-dev-compiler web-hot-reload Issues related to stateful hot reload on the web
Projects
Web Hot Reload - Known Issues
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nshahan @srujzs