Skip to content

testConnectTimeout in secure_socket_test.dart & socket_connect_timeout_test.dart not convincing #60246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
brianquinlan opened this issue Mar 4, 2025 · 0 comments
Open

testConnectTimeout in secure_socket_test.dart & socket_connect_timeout_test.dart not convincing #60246

brianquinlan opened this issue Mar 4, 2025 · 0 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-io P3 A lower priority bug or feature request triaged Issue has been triaged by sub team

Comments

@brianquinlan
Copy link
Contributor

The test assumes that a timeout exception will result when connecting to the IP 8.8.8.7 and does not inspect the exception details.

Instead, the test could use a C helper program (or Dart FFI) that binds to a socket but does not accept connections to simulate connection timeout.
@brianquinlan brianquinlan added library-io P3 A lower priority bug or feature request labels Mar 4, 2025
@mit-mit mit-mit added the area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. label Mar 4, 2025
@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. triaged Issue has been triaged by sub team and removed area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-io P3 A lower priority bug or feature request triaged Issue has been triaged by sub team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@a-siva @brianquinlan @mit-mit