Skip to content

impossible rename on member variable function parameter name #60578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephane-archer opened this issue Apr 22, 2025 · 4 comments
Closed

impossible rename on member variable function parameter name #60578

stephane-archer opened this issue Apr 22, 2025 · 4 comments
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@stephane-archer
Copy link

class CreateSubDirectoryButton extends ConsumerWidget {
  final ButtonStyle? _style;
  final Directory _currentDirectory;
  final void Function(
    Directory directoryToAdd, // try to rename to foo with the vscode renamer
  ) addDirectoryToTreeView; 

  const CreateSubDirectoryButton({
    super.key,
    required Directory currentDirectory,
    required this.addDirectoryToTreeView,
    ButtonStyle? style,
  })  : _currentDirectory = currentDirectory,
        _style = style;

...
}
@stephane-archer stephane-archer added the area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. label Apr 22, 2025
@FMorschel
Copy link
Contributor

I've just tested this with Dart 3.9.0-edge.2936dca6adc0f13444f2dca946a76db713426263. It does work, I think this may have been fixed with #60047, I'll see later if I can find a test for this (to make sure it doesn't break).

@FMorschel
Copy link
Contributor

Here is the CL https://dart-review.googlesource.com/c/sdk/+/423660

@stephane-archer
Copy link
Author

@FMorschel, so this is already solved, we are just waiting for Flutter to use this version?

@FMorschel
Copy link
Contributor

The above-mentioned issue was closed with 1a0b1fe, and it has a 3.8 tag.

If you are using Flutter, you can see whether they have any version on the beta channel that uses Dart 3.8 or later (there probably is, but I've not yet checked), or you can try out the main/master channel, which is usually close to Dart main/master.

But if you are on a purely stable project, yes, you will need to wait until Flutter starts using a Dart version >= 3.8.


P.S.: Please keep this issue open still because the above CL will close it when it lands, thanks!

@srawlins srawlins added P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

3 participants