null error when renaming a variable

[numberbee7070]

If this is a bug report, please help us by providing:

• a clear description of the problem you are experiencing
  • Unable to rename a variable in VS code. Attached output error log of LSP
• the expected and actual behavior, including a repro with the specific code triggering the issue
  • Can not share the source code that caused it
• the Dart SDK version (dart --version)
  • Dart SDK version: 3.7.0 (stable) (Wed Feb 5 04:53:58 2025 -0800) on "linux_x64"

The more information you can provide, the better we can understand and address the issue. Thanks!

[Error - 00:29:18] Request textDocument/rename failed.
  Message: An error occurred while handling textDocument/rename request
  Code: -32001 
[Error - 00:29:18] An error occurred while handling textDocument/rename request: Null check operator used on a null value
#0      RenameProcessor.addDeclarationEdit2 (package:analysis_server/src/services/refactoring/legacy/rename.dart:51:68)
#1      RenameParameterRefactoringImpl.fillChange (package:analysis_server/src/services/refactoring/legacy/rename_parameter.dart:83:19)
#2      RenameRefactoringImpl.createChange (package:analysis_server/src/services/refactoring/legacy/rename.dart:173:11)
#3      RenameHandler.handle.<anonymous closure> (package:analysis_server/src/lsp/handlers/handler_rename.dart:256:38)
<asynchronous suspension>
#4      ErrorOrRecord4Extension.mapResults (package:analysis_server/src/lsp/error_or.dart:217:12)
<asynchronous suspension>
#5      ServerStateMessageHandler.handleMessage (package:analysis_server/src/lsp/handlers/handlers.dart:508:20)
<asynchronous suspension>
#6      LspAnalysisServer._handleRequestMessage (package:analysis_server/src/lsp/lsp_analysis_server.dart:1147:18)
<asynchronous suspension>
#7      LspAnalysisServer.handleMessage.<anonymous closure>.<anonymous closure> (package:analysis_server/src/lsp/lsp_analysis_server.dart:535:15)
<asynchronous suspension>
#8      OperationPerformanceImpl.runAsync (package:analyzer/src/util/performance/operation_performance.dart:174:14)
<asynchronous suspension>
#9      LspAnalysisServer.handleMessage.<anonymous closure> (package:analysis_server/src/lsp/lsp_analysis_server.dart:514:11)
<asynchronous suspension>

[mrcsh]

I have seen this issue come and go on android studio for a while now, I think before I upgraded to flutter 3.29.
For me the failures seems to happen more (possibly exclusively??) on renaming closure parameters rather than formal function parameters or class fields.

[FMorschel]

Hey guys! If that is the error than it has already been fixed at #60047.

[mrcsh]

Oh good, hopefully the fix will be released soon.

[FMorschel]

This is the commit: 1a0b1fe. If you open it on your browser (the GH mobile app doesn't show the tags last time I checked) it will show that this will release on Dart >= 3.8.

[FMorschel]

As noted above I think this has already been solved @srawlins we may close this. Can you confirm?

[srawlins]

Confirmed, thanks for catching, @FMorschel !