Skip to content

Commit 13ee1cd

Browse files
benwtrentdavidkyle
authored andcommitted
fixing data setup for knn yaml tests (elastic#111794)
We should do set up just in the test as that is the only place that uses this index. This way we get around any weird bwc checks around previously required parameters. Additionally, this adjusts the bwc version skip as the code fix has been backported. closes: elastic#111765 closes: elastic#111766 closes: elastic#111767 closes: elastic#111768
1 parent 16ad80c commit 13ee1cd

File tree

2 files changed

+10
-15
lines changed

2 files changed

+10
-15
lines changed

muted-tests.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,6 @@ tests:
125125
- class: org.elasticsearch.tdigest.ComparisonTests
126126
method: testSparseGaussianDistribution
127127
issue: https://github.com/elastic/elasticsearch/issues/111721
128-
- class: org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT
129-
issue: https://github.com/elastic/elasticsearch/issues/111765
130128
- class: org.elasticsearch.upgrades.FullClusterRestartIT
131129
method: testSnapshotRestore {cluster=OLD}
132130
issue: https://github.com/elastic/elasticsearch/issues/111777

rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.vectors/40_knn_search.yml

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,17 +28,6 @@ setup:
2828
type: hnsw
2929
m: 16
3030
ef_construction: 200
31-
32-
- do:
33-
indices.create:
34-
index: test_empty
35-
body:
36-
mappings:
37-
properties:
38-
vector:
39-
type: dense_vector
40-
41-
4231
- do:
4332
index:
4433
index: test
@@ -530,8 +519,16 @@ setup:
530519
---
531520
"kNN search on empty index should return 0 results and not an error":
532521
- requires:
533-
cluster_features: "gte_v8.16.0"
534-
reason: 'Error fixed in 8.16.0'
522+
cluster_features: "gte_v8.15.1"
523+
reason: 'Error fixed in 8.15.1'
524+
- do:
525+
indices.create:
526+
index: test_empty
527+
body:
528+
mappings:
529+
properties:
530+
vector:
531+
type: dense_vector
535532
- do:
536533
search:
537534
index: test_empty

0 commit comments

Comments
 (0)