Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: deephaven/web-client-ui
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: deephaven/web-client-ui
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release/v0.41
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 79 files changed
  • 6 contributors

Commits on Jun 13, 2023

  1. Create release/v0.41 branch

    vbabich committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    d1c90fb View commit details
    Browse the repository at this point in the history
  2. fix: DH-15032: Fix incorrect warning about updated shared state (#1364)…

    … (#1371)
    
    - Update dehydration methods to return null instead of undefined
    - Add unit tests to catch similar dehydration bugs the future
    vbabich authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    109f47e View commit details
    Browse the repository at this point in the history
  3. v0.41.2

    vbabich committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    8c75d85 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. fix: AuthPluginParent wasn't working when embedded in an iframe (#1383)…

    … (#1384)
    
    - Check for window.opener _or_ window.parent when using AuthPluginParent
    - Reorder plugin priority to use AuthPluginParent first if specified
    - Tested using an example html page that both embeds and pops open a new
    tab
    - Fixes #1373
    - Cherry-pick of #1383
    mofojed authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    7e38af3 View commit details
    Browse the repository at this point in the history
  2. v0.41.3

    mofojed committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    e99b6e8 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. fix: Change display of rollup key columns from null to empty string (#…

    …1563) (#1630)
    
    Cherry-pick of #1563. Also added a few lines from #1365 that were needed to make this work
    
    * Previously, key columns containing non-numeric types would display
    `null` is the rolled up rows have different values for the same column
        * This behaviour is updated to show an empty cell instead of `null`
    * Resolves #1483 
    
    #### Testing Instructions:
    1. Run: 
    ```python 
    from deephaven import empty_table, time_table
      
      size = 100
      scale = 1000
      
      random_values_with_null_NaN = empty_table(size).update([
          "MyString=(i%11==0? null : `a`+(int)(scale*(Math.random()*2-1)))"
      ])
    ```
    2. Add the string and char columns and any other arbitrary columns as
    rollup columns in any order
    3. The key column should only show `null` if it actually represents a
    null value in the column
    
    ---------
    
    ---------
    
    Co-authored-by: George Wan <[email protected]>
    Co-authored-by: georgecwan <[email protected]>
    Co-authored-by: Mike Bender <[email protected]>
    4 people authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    d0e50ca View commit details
    Browse the repository at this point in the history
  2. v0.41.4

    mattrunyon committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    78f6869 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. fix: address chrome 121 scrollbar style behaviour change (#1787) (#1791)

    Chrome adopted offical support for scrollbar-color in chrome 121.
    However, if you have both scrollbar-color and ::webkit-scrollbar
    styling, they conflict and chrome will only honour the native styling.
    This is bad because the native chrome mac scrollbars become really
    small, and overlap too much with out golden-layout drag.
    
    Our webkit styling forces scrollbars that match monaco and grid, and are
    preferred. By removing `scrollbar-color` native styling, our webkit
    styles work. We only had scrollbar-color to style firefox in dark mode
    (`//applies to firefox only` is no longer true), however the most recent
    versions of firefox appear to color scrollbars automatically based on
    the theme, so this is no longer necessary.
    
    The crappy part here is since this is browser change, we will have to
    backport this for several active enterprise versions.
    
    See:
    -
    
    https://stackoverflow.com/questions/77919700/scrollbars-chrome-update-121
    - https://issues.chromium.org/issues/41494676
    
    Co-authored-by: Don <[email protected]>
    mofojed and dsmmcken authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d065679 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. v0.41.5

    mofojed committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    b80d4da View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. fix: Cannot import CSV with LOCAL_TIME (#1434) (#1915)

    - Fix adding error console history items
    - They weren't appearing as anything because the command was `''`
    instead of `undefined`
    - Map LOCAL_TIME to STRING on CSV import
    - `LOCAL_TIME` isn't supported on the server in DHC, and isn't really
    "safe" anyways since we should have other info in there as well (e.g.
    date or time zone)
    - When exporting, should be exporting the 'unformatted' value, which
    gives you the full timestamp
    - By mapping to String, user can then do an `.update_view` to map it to
    a timestamp if they wish
    - Fixes #1432
    - Cherry-pick back for DH-15013. Tested against dev-vermilion.
    mofojed authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    27fae23 View commit details
    Browse the repository at this point in the history
  2. v0.41.6

    mofojed committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    8d78948 View commit details
    Browse the repository at this point in the history
Loading