Skip to content

Commit f2c55a4

Browse files
author
Allison Gruninger
authored
Update azfiles error string, add hrefs to error events (#3002)
1 parent 6bf86fe commit f2c55a4

File tree

5 files changed

+13
-3
lines changed

5 files changed

+13
-3
lines changed

client/src/app/error-list/error-list.component.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ export class ErrorListComponent {
2626
dateTime: new Date().toISOString(),
2727
date: new Date(),
2828
errorIds: [error.errorId],
29-
dismissable: true
29+
dismissable: true,
30+
href: error.href,
31+
hrefText: error.hrefText
3032
};
3133
const existingError = this.errorList.find(e => e.message === errorItem.message);
3234
if (existingError && !existingError.errorIds.find(e => e === error.errorId)) {

client/src/app/shared/models/error-event.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,6 @@ export interface ErrorEvent {
33
message: string;
44
errorId: string;
55
resourceId: string;
6+
href?: string;
7+
hrefText?: string;
68
}

client/src/app/shared/models/portal-resources.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1189,4 +1189,5 @@
11891189
public static communityTemplatesTitle = 'communityTemplatesTitle';
11901190
public static communityTemplatesDescription = 'communityTemplatesDescription';
11911191
public static scmPingFailedErrorMessage = 'scmPingFailedErrorMessage';
1192+
public static scmPingFailedLearnMore = 'scmPingFailedLearnMore';
11921193
}

client/src/app/site/site-summary/site-summary.component.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,9 @@ export class SiteSummaryComponent extends FeatureComponent<TreeViewInfo<SiteData
161161
this.showComponentError({
162162
message: this.ts.instant(PortalResources.scmPingFailedErrorMessage),
163163
errorId: errorIds.preconditionsErrors.failedToPingScmSite,
164-
resourceId: this.context.site.id
164+
resourceId: this.context.site.id,
165+
href: 'http://aka.ms/func-storage',
166+
hrefText: this.ts.instant(PortalResources.scmPingFailedLearnMore)
165167
});
166168
}
167169

server/Resources/Resources.resx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3707,6 +3707,9 @@ Set to "External URL" to use an API definition that is hosted elsewhere.</value>
37073707
<value>Not finding what you’re looking for? Check out the Serverless Library, our gallery of community created templates, for inspiration!</value>
37083708
</data>
37093709
<data name="scmPingFailedErrorMessage" xml:space="preserve">
3710-
<value>Unable to reach scm site. Please check your Function Storage account connection.</value>
3710+
<value>Azure Functions Runtime is unreachable.</value>
3711+
</data>
3712+
<data name="scmPingFailedLearnMore" xml:space="preserve">
3713+
<value>Click here for details on storage configuration.</value>
37113714
</data>
37123715
</root>

0 commit comments

Comments
 (0)