Skip to content

Wrong parsing of 3 word name starting with prefix #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
curita opened this issue May 21, 2021 · 1 comment
Closed

Wrong parsing of 3 word name starting with prefix #126

curita opened this issue May 21, 2021 · 1 comment
Labels

Comments

@curita
Copy link

curita commented May 21, 2021

Parsing the name "Van Maximilian Carlson" fails to recognize any part as last name.

$ python tests.py "Van Maximilian Carlson"
<HumanName : [
	title: ''
	first: 'Van Maximilian Carlson'
	middle: ''
	last: ''
	suffix: ''
	nickname: ''
]>

I think I would expect this case to be treated like when there's two words, the first starting with a prefix, when the prefix is considered the first name, something like:

<HumanName : [
	title: ''
	first: 'Van'
	middle: 'Maximilian'
	last: 'Carlson'
	suffix: ''
	nickname: ''
]>

But it might be something related to that specific prefix, as "Van" can often be a name.

I fixed locally by removing "van" from the prefixes config list, but I wanted to raise this issue in case it's worth it to address in the project.

@derek73
Copy link
Owner

derek73 commented May 21, 2021

Thanks for the raising the issue. I didn't realize Van could be a first name too. We should remove it from the constants list.

@derek73 derek73 added the bug label May 21, 2021
@derek73 derek73 closed this as completed in 2a3edae Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants