Skip to content

capitalize should regenerate full_name #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
twall opened this issue Jun 26, 2019 · 2 comments
Closed

capitalize should regenerate full_name #87

twall opened this issue Jun 26, 2019 · 2 comments
Assignees
@derek73
Labels
bug
Milestone
v1.0.4

Comments

@twall
Copy link

twall commented Jun 26, 2019 •
edited
Loading 

obj = NameParser("UNILEVER LTD")
obj.full_name # "UNILEVER LTD"
obj.capitalize(force=True)
obj.full_name # "UNILEVER LTD" instead of "Unilever Ltd", even though other internal fields have been updated
@derek73 derek73 added this to the v1.0.4 milestone Jun 27, 2019
@derek73 derek73 added the bug label Jun 27, 2019
@derek73 derek73 self-assigned this Jun 27, 2019
@derek73
Copy link
Owner

derek73 commented Jun 27, 2019 •
edited
Loading

fixed in 13bc95b

@derek73 derek73 closed this as completed Jun 27, 2019
@derek73
Copy link
Owner

derek73 commented Jun 27, 2019

Thanks for the bug report. I think this was left over from when full_name was functioning more like a reference to the original name, but now there is original_name for that. Returning the current formatted string output makes more sense, even if it's just a reference to str(obj).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derek73 derek73

Labels
bug
Projects
None yet
Milestone
v1.0.4
Development

No branches or pull requests
2 participants
@derek73 @twall