Enable context menu from keyboard in History view #17035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
reviewed
Jul 7, 2023
| @@ -31,31 +23,20 @@ interface ICommitProps { | |||
| readonly commit: Commit | |||
| readonly selectedCommits: ReadonlyArray<Commit> | |||
| readonly emoji: Map<string, string> | |||
| readonly isLocal: boolean | |||
There was a problem hiding this comment.
Dude. I think this was the roughest one so far since the commit list items have so many things. :P
tidy-dev
reviewed
Jul 7, 2023
| @@ -289,6 +269,15 @@ export class CommitList extends React.Component<ICommitListProps, {}> { | |||
| return undefined | |||
| } | |||
|
|
|||
| private get selectedCommits() { | |||
There was a problem hiding this comment.
Nice tidy convenience functions added in this file.
tidy-dev
reviewed
Jul 7, 2023
tidy-dev
reviewed
Jul 7, 2023
tidy-dev
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
✨ Works as expected!
I only did a cursory regression test on macOS against it to just make sure all the context menu items fire. Looks like a pretty straight forwards lift and shift, thus, I don't see anything to indicate a regression would be present famous last words.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref. https://github.com/github/accessibility-audits/issues/4916
Description
This PR moves context menu control from the
CommitListItemto theCommitListin order to make it accessible via keyboard.Release notes
Notes: [Improved] The context menu for the History view items can be invoked by keyboard shortcuts