Ensure custom build hooks consume DOCKERFILE_PATH #6026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a custom build hook to pass in build arguments on a repository from which I build two Docker images (tags), from two Dockerfiles. My second build, however, with the custom Dockerfile, was not being built correctly. It was being built with the default `Dockerfile`, instead of my specified custom one. I quickly figured out the custom build hook was to blame because it doesn't specify which Dockerfile it should build from, but there was no mention in the documentation of an environmental variable I can consume to get the custom "Dockerfile location" value. By dumping the env vars during the build process, I can there is an environmental variable with that value: `DOCKERFILE_PATH`. This PR updates the documentation accordingly, to: 1) Expose the fact this environmental variable exists, and explains its purpose 2) Make sure its consumed in the example custom build hook, so any copy-pasters find themselves already supporting custom Dockerfiles, rather than struggling with the same problem
|
@KickingTheTV can you confirm that we set the |
pchico83
approved these changes
Feb 24, 2018
|
Thanks! Let's ship it 🚀 |
shin-
pushed a commit
to shin-/docker.github.io
that referenced
this pull request
Mar 1, 2018
I have a custom build hook to pass in build arguments on a repository from which I build two Docker images (tags), from two Dockerfiles. My second build, however, with the custom Dockerfile, was not being built correctly. It was being built with the default `Dockerfile`, instead of my specified custom one. I quickly figured out the custom build hook was to blame because it doesn't specify which Dockerfile it should build from, but there was no mention in the documentation of an environmental variable I can consume to get the custom "Dockerfile location" value. By dumping the env vars during the build process, I can there is an environmental variable with that value: `DOCKERFILE_PATH`. This PR updates the documentation accordingly, to: 1) Expose the fact this environmental variable exists, and explains its purpose 2) Make sure its consumed in the example custom build hook, so any copy-pasters find themselves already supporting custom Dockerfiles, rather than struggling with the same problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a custom build hook to pass in build arguments on a repository from which I build two Docker images (tags), from two Dockerfiles.
My second build, however, with the custom Dockerfile, was not being built correctly. It was being built with the default
Dockerfile, instead of my specified custom one.I quickly figured out the custom build hook was to blame because it doesn't specify which Dockerfile it should build from, but there was no mention in the documentation of an environmental variable I can consume to get the custom "Dockerfile location" value. By dumping the env vars during the build process, I can there is an environmental variable with that value:
DOCKERFILE_PATH.This PR updates the documentation accordingly, to:
Proposed changes
Unreleased project version (optional)
Related issues (optional)