Enable CA1805 diagnostics #32893
Merged
Enable CA1805 diagnostics #32893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
requested review from
a team,
BrennanConroy,
Pilchie,
Tratcher,
halter73 and
javiercn
as code owners
mkArtakMSFT
added
the
area-infrastructure
TanayParikh
approved these changes
May 21, 2021
src/Razor/Microsoft.AspNetCore.Mvc.Razor.Extensions/src/MvcViewDocumentClassifierPass.cs
Outdated
Show resolved
Hide resolved
…wDocumentClassifierPass.cs Co-authored-by: Tanay Parikh <[email protected]>
Tratcher
approved these changes
May 21, 2021
| /// </summary> | ||
| public readonly struct ParsedPath | ||
| { | ||
| private static readonly string[] Empty = null; |
Member
There was a problem hiding this comment.
This smells like a bug, are we sure this wasn't supposed to return Array.Empty<byte>()?
Contributor
Author
There was a problem hiding this comment.
Probably, but I don't really feel like digging up JsonPatch code 😄
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.