Skip to content

Investigate why two predictor tests fail with "Unknown command: 'train'" on x86 #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tannergooding opened this issue Oct 10, 2018 · 2 comments · Fixed by #5081
Closed

Investigate why two predictor tests fail with "Unknown command: 'train'" on x86 #1216

tannergooding opened this issue Oct 10, 2018 · 2 comments · Fixed by #5081
Assignees
@frank-dong-ms-zz
Labels
bug Something isn't working P1 Priority of the issue for triage purpose: Needs to be fixed soon. test related to tests

Comments

@tannergooding
Copy link
Member

There are currently two TestPredictors tests disabled on x86 due to: [ConditionalFact(typeof(Environment), nameof(Environment.Is64BitProcess))] // x86 fails with "Unknown command: 'train'; Format error at (83,3)-(83,4011): Illegal quoting".

This issue needs further investigation.
@tannergooding tannergooding mentioned this issue Oct 10, 2018
Merged
@justinormont justinormont added bug Something isn't working test related to tests labels Oct 17, 2018
@tannergooding tannergooding mentioned this issue Oct 23, 2018
Merged
@artidoro
Copy link
Contributor

@tannergooding are you looking into this?

@codemzs codemzs added the P1 Priority of the issue for triage purpose: Needs to be fixed soon. label Jun 30, 2019
@gvashishtha gvashishtha added P0 Priority of the issue for triage purpose: IMPORTANT, needs to be fixed right away. and removed P1 Priority of the issue for triage purpose: Needs to be fixed soon. labels Jan 9, 2020
@harishsk harishsk added P1 Priority of the issue for triage purpose: Needs to be fixed soon. and removed P0 Priority of the issue for triage purpose: IMPORTANT, needs to be fixed right away. labels Apr 21, 2020
@frank-dong-ms-zz
Copy link
Contributor

Following test are marking with this issue but they appear to have different reason of fail:

  1. TestMulticlassEnsembleCombiner: this is lightgbm test and should be marked as LightGBMFact and only runs on x64
  2. TestTreeEnsembleCombiner: Heap corruption
  3. TestTreeEnsembleCombinerWithCategoricalSplits: Heap corruption
  4. TestEnsembleCombiner: Heap corruption

@frank-dong-ms-zz frank-dong-ms-zz mentioned this issue May 2, 2020
Merged
@frank-dong-ms-zz frank-dong-ms-zz mentioned this issue May 16, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@frank-dong-ms-zz frank-dong-ms-zz

Labels
bug Something isn't working P1 Priority of the issue for triage purpose: Needs to be fixed soon. test related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix x86 crash frank-dong-ms-zz/machinelearning
9 participants
@codemzs @justinormont @harishsk @tannergooding @Lynx1820 @artidoro @gvashishtha @antoniovs1029 @frank-dong-ms-zz