Skip to content

Add components to EntryPoint catalog that are missing. #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
montebhoover opened this issue Dec 7, 2018 · 4 comments
Open

Add components to EntryPoint catalog that are missing. #1853

montebhoover opened this issue Dec 7, 2018 · 4 comments
Labels
P2 Priority of the issue for triage purpose: Needs to be fixed at some point.

Comments

@montebhoover
Copy link
Contributor

There are several new components in ML.NET that were not added to the EntryPoint catalog:

  • MatrixFactorizationTrainer
  • PermutationFeatureImportance
  • GeneralizedAdditiveModels
  • SsaSpikeDetector
  • SsaChangePointDetector
  • IidSpikeDetector
  • IidChangePointDetector

To add these to the EntryPoint catalog, simply:

  1. Add the SignatureEntryPointModule signature to the LoadableClass assembly attribute.
  2. Create a public static method, that:
    1. Takes as input, among others, an object representing the arguments of the component you want to expose.
    2. Initializes and run the components, returning one of the nested classes of Microsoft.ML.Runtime.EntryPoints.CommonOutputs
    3. Is annotated with the TlcModule.EntryPoint attribute
@montebhoover montebhoover self-assigned this Dec 7, 2018
@montebhoover
Copy link
Contributor Author

These have been added:

SsaSpikeDetector
SsaChangePointDetector
IidSpikeDetector
IidChangePointDetector

@codemzs
Copy link
Member

codemzs commented Jun 30, 2019 •
edited
Loading

SsaSpikeDetector
SsaChangePointDetector
IidSpikeDetector
IidChangePointDetector

already have entry points.

@wschin @artidoro can you please confirm for:
MatrixFactorizationTrainer
PermutationFeatureImportance
GeneralizedAdditiveModels

@codemzs codemzs closed this as completed Jun 30, 2019
@codemzs codemzs reopened this Jun 30, 2019
@codemzs codemzs added the P1 Priority of the issue for triage purpose: Needs to be fixed soon. label Jun 30, 2019
@artidoro
Copy link
Contributor

artidoro commented Jul 2, 2019

Gam also has entrypoints.

@harishsk harishsk added P2 Priority of the issue for triage purpose: Needs to be fixed at some point. and removed P1 Priority of the issue for triage purpose: Needs to be fixed soon. labels Jan 10, 2020
@najeeb-kazmi
Copy link
Member

PermutationFeatureImportance also has an entrypoint (PR #4232). The only one remaining from this list is:

  • MatrixFactorizationTrainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Priority of the issue for triage purpose: Needs to be fixed at some point.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@codemzs @harishsk @artidoro @najeeb-kazmi @montebhoover