Skip to content

TreeEnsembleFeaturizer is not a Transformer yet #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wschin opened this issue Feb 8, 2019 · 4 comments · Fixed by #3812
Closed

TreeEnsembleFeaturizer is not a Transformer yet #2482

wschin opened this issue Feb 8, 2019 · 4 comments · Fixed by #3812
Assignees
Labels
enhancement New feature or request P0 Priority of the issue for triage purpose: IMPORTANT, needs to be fixed right away.

Comments

@wschin
Copy link
Member

wschin commented Feb 8, 2019

TreeEnsembleFeaturizer is a very useful tool in many applications. Do we have a plan to make it publicly available?

cc @shauheen, @Ivanidzo4ka, @TomFinley, @yaeldekel.

@TomFinley
Copy link
Contributor

This strikes me as being quite conceptually similar to #2465 -- that is, in both cases, we have a "default" way of scoring given a trained model, but we want to expose a way in which to reconfigure how that scoring happens... in that other issue, we want to set a different threshold, in this issue, we want to enable more parameters.

One place we "solve" this "changed outputs" problem for models is what we did for permutation feature importance:

PermutationFeatureImportance(
this RegressionCatalog catalog,
IPredictionTransformer<IPredictor> model,

If people agree this is a good idiom, we could conceivably do something similar here.

@TomFinley
Copy link
Contributor

I might however identify this as work that could easily be completed post v1, since it represents new functionality, and as useful as it may be, we did after all at least internally survive years without having it, so maybe a month or two without it for v1 won't kill us? 😄

@rogancarr
Copy link
Contributor

For thresholds, that's in our core "I cans" for v1.

If we can't guarantee that we'll get to it, maybe we can add a "dearly hoped for v1 features" stretch goals.

@TomFinley
Copy link
Contributor

For thresholds, that's in our core "I cans" for v1.
If we can't guarantee that we'll get to it, maybe we can add a "dearly hoped for v1 features" stretch goals.

Sure @rogancarr. However, this issue isn't about thresholds, it's about tree featurization I think. You have a separate issue #2465 for that work. What I'm doing though, is identifying that the two might benefit from a similar approach.

@wschin wschin added P0 Priority of the issue for triage purpose: IMPORTANT, needs to be fixed right away. enhancement New feature or request labels May 21, 2019
@wschin wschin self-assigned this May 28, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request P0 Priority of the issue for triage purpose: IMPORTANT, needs to be fixed right away.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants