Skip to content

Samples width: they need to be formatted at 85 characters or less. #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
codemzs opened this issue Apr 22, 2019 · 1 comment
Closed

Samples width: they need to be formatted at 85 characters or less. #3478

codemzs opened this issue Apr 22, 2019 · 1 comment
Assignees
@codemzs @artidoro @sierralee51 @sayanshaw24
Labels
documentation Related to documentation of ML.NET P0 Priority of the issue for triage purpose: IMPORTANT, needs to be fixed right away.

Comments

@codemzs
Copy link
Member

codemzs commented Apr 22, 2019

Also add rule in VS settings file to throw error.

CC: @natke @shmoradims
@codemzs codemzs self-assigned this Apr 22, 2019
@codemzs codemzs mentioned this issue Apr 25, 2019
Closed
@shmoradims shmoradims added documentation Related to documentation of ML.NET and removed Bug Bash labels Apr 25, 2019
@shmoradims
Copy link

We cut this from V1 bugbash. It requires manual fixes to all the samples to make sure they don't look ugly. Automated tools don't cut it. Also need to change the T4 templates.

@codemzs codemzs mentioned this issue Apr 25, 2019
Merged
@artidoro artidoro mentioned this issue Apr 25, 2019
Merged
@shmoradims shmoradims added the P0 Priority of the issue for triage purpose: IMPORTANT, needs to be fixed right away. label May 21, 2019
@sierralee51 sierralee51 mentioned this issue Jun 27, 2019
Merged
This was referenced Jun 27, 2019
Merged
Merged
Closed
Closed
Merged
@sierralee51 sierralee51 mentioned this issue Jul 1, 2019
Merged
@rayankrish rayankrish mentioned this issue Jul 1, 2019
Merged
@sierralee51 sierralee51 mentioned this issue Jul 2, 2019
Merged
@rayankrish rayankrish mentioned this issue Jul 2, 2019
Merged
@sayanshaw24 sayanshaw24 mentioned this issue Jul 2, 2019
Merged
@sierralee51 sierralee51 mentioned this issue Jul 2, 2019
Merged
@rayankrish rayankrish mentioned this issue Jul 2, 2019
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@codemzs codemzs

@artidoro artidoro

@sierralee51 sierralee51

@sayanshaw24 sayanshaw24

Labels
documentation Related to documentation of ML.NET P0 Priority of the issue for triage purpose: IMPORTANT, needs to be fixed right away.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Samples width: they need to be formatted at 85 characters or less. codemzs/machinelearning
5 participants
@codemzs @artidoro @shmoradims @sierralee51 @sayanshaw24