Skip to content

Improve "Invalid TValue" error message #4047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
justinormont opened this issue Jul 29, 2019 · 0 comments
Closed

Improve "Invalid TValue" error message #4047

justinormont opened this issue Jul 29, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request P1 Priority of the issue for triage purpose: Needs to be fixed soon. usability Smoothing user interaction or experience

Comments

@justinormont
Copy link
Contributor

When throwing "Invalid TValue" runtime errors, we tell users which type they entered, but don't tell the user the type that is needed. We tell them their current type is wrong, but not the right type.

There are current 23 places we throw this error. Our most common is when calling a GetGetter().

The one I'm hitting at the moment:

throw Ch.Except("Invalid TValue: '{0}'", typeof(TValue));

Task:

To make this more actionable, we should tell the user which type is needed for the column type.

@justinormont justinormont added enhancement New feature or request usability Smoothing user interaction or experience labels Jul 29, 2019
@mstfbl mstfbl added the P1 Priority of the issue for triage purpose: Needs to be fixed soon. label Jan 9, 2020
@frank-dong-ms-zz frank-dong-ms-zz self-assigned this Jun 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request P1 Priority of the issue for triage purpose: Needs to be fixed soon. usability Smoothing user interaction or experience
Projects
None yet
Development

No branches or pull requests

3 participants