-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Replace usages of TPL DataFlow BufferBlock with Threading.Channels #4482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
good first issue
Good for newcomers
P2
Priority of the issue for triage purpose: Needs to be fixed at some point.
up-for-grabs
A good issue to fix if you are trying to contribute to the project
Comments
I, Can I try do this? |
@mariombaltazar -Yes! Feel free. |
I @eerhardt, |
Here's the steps to create a pull request:
|
Hi @mariombaltazar , are you still interested in working on this issue? |
Hi @campiador . It is still an unsolved issue, and it seems that @mariombaltazar isn't working on it, so you can go for it 😃 |
Close this issue and this already been addressed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
good first issue
Good for newcomers
P2
Priority of the issue for triage purpose: Needs to be fixed at some point.
up-for-grabs
A good issue to fix if you are trying to contribute to the project
There are 2 places we are using
BufferBlock<T>
today:machinelearning/src/Microsoft.ML.Data/Transforms/RowShufflingTransformer.cs
Lines 486 to 487 in b7db4fa
machinelearning/src/Microsoft.ML.Sweeper/AsyncSweeper.cs
Line 171 in b7db4fa
We should consider replacing this dependency with https://www.nuget.org/packages/System.Threading.Channels/ instead. Channels are a bit simpler, and more performant than BufferBlock.
See:
The text was updated successfully, but these errors were encountered: