Skip to content

Replace usages of TPL DataFlow BufferBlock with Threading.Channels #4482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eerhardt opened this issue Nov 15, 2019 · 8 comments
Closed

Replace usages of TPL DataFlow BufferBlock with Threading.Channels #4482

eerhardt opened this issue Nov 15, 2019 · 8 comments
Labels
good first issue Good for newcomers P2 Priority of the issue for triage purpose: Needs to be fixed at some point. up-for-grabs A good issue to fix if you are trying to contribute to the project

Comments

@eerhardt
Copy link
Member

There are 2 places we are using BufferBlock<T> today:

private readonly BufferBlock<int> _toProduce;
private readonly BufferBlock<int> _toConsume;

private readonly BufferBlock<ParameterSetWithId> _paramQueue;

We should consider replacing this dependency with https://www.nuget.org/packages/System.Threading.Channels/ instead. Channels are a bit simpler, and more performant than BufferBlock.

See:

@harishsk harishsk added good first issue Good for newcomers up-for-grabs A good issue to fix if you are trying to contribute to the project labels Nov 15, 2019
@mariombaltazar
Copy link

I, Can I try do this?

@eerhardt
Copy link
Member Author

@mariombaltazar -Yes! Feel free.

@mariombaltazar
Copy link

I @eerhardt,
I can not do pull request. can you help me?

@eerhardt
Copy link
Member Author

eerhardt commented Dec 3, 2019

Here's the steps to create a pull request:

  1. Fork the repo - https://help.github.com/en/github/getting-started-with-github/fork-a-repo
  2. Push your changes to that fork
  3. Create the PR from your fork - https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

@mstfbl mstfbl added the P2 Priority of the issue for triage purpose: Needs to be fixed at some point. label Jan 9, 2020
@mstfbl
Copy link
Contributor

mstfbl commented Jan 9, 2020

Hi @mariombaltazar , are you still interested in working on this issue?

@campiador
Copy link

campiador commented Feb 4, 2020

@eerhardt @mstfbl Hi! In case this issue is available, may I please start working on it?

@antoniovs1029
Copy link
Member

Hi @campiador . It is still an unsolved issue, and it seems that @mariombaltazar isn't working on it, so you can go for it 😃

@frank-dong-ms-zz
Copy link
Contributor

Close this issue and this already been addressed.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers P2 Priority of the issue for triage purpose: Needs to be fixed at some point. up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Development

No branches or pull requests

7 participants