Skip to content

Spelling: stopwrods #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
justinormont opened this issue Nov 28, 2020 · 1 comment · Fixed by #5524
Closed

Spelling: stopwrods #5514

justinormont opened this issue Nov 28, 2020 · 1 comment · Fixed by #5524
Labels
good first issue Good for newcomers up-for-grabs A good issue to fix if you are trying to contribute to the project

Comments

@justinormont
Copy link
Contributor

Our stop word remover has a variable misspelt as stopwrods instead of stopwords:

NormStr.Pool stopwrods = null;
bool res = ctx.TryProcessSubModel(dir,
c =>
{
Host.CheckValue(c, nameof(ctx));
c.CheckAtModel(GetStopwordsManagerVersionInfo());
// *** Binary format ***
// int: number of stopwords
// int[]: stopwords string ids
int cstr = ctx.Reader.ReadInt32();
Host.CheckDecode(cstr > 0);
stopwrods = new NormStr.Pool();
for (int istr = 0; istr < cstr; istr++)
{
var nstr = stopwrods.Add(ctx.LoadString());
Host.CheckDecode(nstr.Id == istr);
}
// All stopwords are distinct.
Host.CheckDecode(stopwrods.Count == cstr);
// The deserialized pool should not have the empty string.
Host.CheckDecode(stopwrods.Get("") == null);
});
if (!res)
throw Host.ExceptDecode();
_stopWordsMap = stopwrods;

@justinormont justinormont added good first issue Good for newcomers up-for-grabs A good issue to fix if you are trying to contribute to the project labels Nov 28, 2020
@LeoGaunt
Copy link
Contributor

LeoGaunt commented Dec 2, 2020

I have created a pull request #5524 to fix this spelling error

@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers up-for-grabs A good issue to fix if you are trying to contribute to the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants