Skip to content

Potential bug in empty column computations in DataFrame #5836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pgovind opened this issue Jun 4, 2021 · 0 comments
Open

Potential bug in empty column computations in DataFrame #5836

pgovind opened this issue Jun 4, 2021 · 0 comments
Labels
Microsoft.Data.Analysis All DataFrame related issues and PRs

Comments

@pgovind
Copy link

pgovind commented Jun 4, 2021

If a PrimitiveDataFrameColumn<T> is empty, and CumulativeMax is called, a null dereference may occur and cause a crash. See https://source.dot.net/#Microsoft.Data.Analysis/PrimitiveDataFrameColumnComputations.cs,264

The fix is simple, but it needs to be applied to the tt file. Many computation APIs are affected. The fix should also apply to DateTImeComputations.cs
@pgovind pgovind added the Microsoft.Data.Analysis All DataFrame related issues and PRs label Jun 4, 2021
@pgovind pgovind mentioned this issue Jun 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Microsoft.Data.Analysis All DataFrame related issues and PRs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pgovind