Skip to content

Split struct should not be readonly #7009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stephentoub opened this issue Feb 16, 2024 · 2 comments
Closed

Split struct should not be readonly #7009

stephentoub opened this issue Feb 16, 2024 · 2 comments
Assignees
@tarekgh
Labels
bug Something isn't working

Comments

@stephentoub
Copy link
Member

Doing so prohibits desirable optimizations, like making the TokenString property lazily initialized from the original string (otherwise, we end up allocating a new string for every split even if the string isn't used).
@stephentoub
Copy link
Member Author

cc: @tarekgh

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged label Feb 16, 2024
@tarekgh tarekgh self-assigned this Feb 16, 2024
@tarekgh tarekgh added bug Something isn't working and removed untriaged New issue has not been triaged labels Feb 16, 2024
@stephentoub stephentoub mentioned this issue Feb 17, 2024
Merged
@stephentoub
Copy link
Member Author

addressed in #7012

@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tarekgh tarekgh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephentoub @tarekgh