Skip to content

Django 1.10 compatibility #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tehfink opened this issue Oct 31, 2017 · 3 comments
Closed

Django 1.10 compatibility #2

tehfink opened this issue Oct 31, 2017 · 3 comments
Labels

Comments

@tehfink
Copy link

tehfink commented Oct 31, 2017

Django: 1.10.8
Python: 3.6.3

With middleware enabled in settings.py, the following error occurs:

Unhandled exception in thread started by <function check_errors.<locals>.wrapper at 0x10ed9bea0>
Traceback (most recent call last):
  File "/Users/tehfink/Documents/work/mylittlepony.net/www./source/3.0/mlp_website-virtualenv/lib/python3.6/site-packages/django/utils/autoreload.py", line 226, in wrapper
    fn(*args, **kwargs)
  File "/Users/tehfink/Documents/work/mylittlepony.net/www./source/3.0/mlp_website-virtualenv/lib/python3.6/site-packages/django/core/management/commands/runserver.py", line 142, in inner_run
    handler = self.get_handler(*args, **options)
  File "/Users/tehfink/Documents/work/mylittlepony.net/www./source/3.0/mlp_website-virtualenv/lib/python3.6/site-packages/django/contrib/staticfiles/management/commands/runserver.py", line 27, in get_handler
    handler = super(Command, self).get_handler(*args, **options)
  File "/Users/tehfink/Documents/work/mylittlepony.net/www./source/3.0/mlp_website-virtualenv/lib/python3.6/site-packages/django/core/management/commands/runserver.py", line 64, in get_handler
    return get_internal_wsgi_application()
  File "/Users/tehfink/Documents/work/mylittlepony.net/www./source/3.0/mlp_website-virtualenv/lib/python3.6/site-packages/django/core/servers/basehttp.py", line 46, in get_internal_wsgi_application
    return get_wsgi_application()
  File "/Users/tehfink/Documents/work/mylittlepony.net/www./source/3.0/mlp_website-virtualenv/lib/python3.6/site-packages/django/core/wsgi.py", line 14, in get_wsgi_application
    return WSGIHandler()
  File "/Users/tehfink/Documents/work/mylittlepony.net/www./source/3.0/mlp_website-virtualenv/lib/python3.6/site-packages/django/core/handlers/wsgi.py", line 153, in __init__
    self.load_middleware()
  File "/Users/tehfink/Documents/work/mylittlepony.net/www./source/3.0/mlp_website-virtualenv/lib/python3.6/site-packages/django/core/handlers/base.py", line 82, in load_middleware
    mw_instance = middleware(handler)
TypeError: object() takes no parameters
@tehfink
Copy link
Author

tehfink commented Dec 27, 2017

Ping!

@daneah
Copy link
Member

daneah commented Jan 2, 2018

Hey @tehfink, I'm only now seeing this so I apologize profusely. I just saw another user has updated their fork for Django 2.0 compatibility, so I'm keen to get this up to snuff on both versions soon. Sorry again for the delay but I'll keep you posted!

@daneah
Copy link
Member

daneah commented Jan 2, 2018

@tehfink I've made a pull request (referenced just above) and would appreciate a quick review of the code if you have time! Meanwhile I'm running the test suites against all combinations of:

  • Python 3.4, 3.5, 3.6 (latest patch versions)
  • Django 1.8, 1.9, 1.10, 1.11, 2.0 (latest patch versions)

cc'ing @things as well since I see you did some Django 2.0 work on your fork. I made similar changes but kept things working for Django < 2.0 since others made not make the switch just for this little ol' library 😉

@daneah daneah closed this as completed in #3 Jan 3, 2018
@daneah daneah removed their assignment Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants