Skip to content

Commit fd5fc22

Browse files
committed
add comment
1 parent 74ccbb6 commit fd5fc22

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/inference/results/SparseEmbeddingResults.java

+2
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,8 @@ public String toString() {
175175

176176
@Override
177177
public Embedding merge(Embedding embedding) {
178+
// This code assumes that the tokens are sorted by weight in descending order.
179+
// If that's not the case, the resulting merged embedding will be incorrect.
178180
List<WeightedToken> mergedTokens = new ArrayList<>();
179181
Set<String> seenTokens = new HashSet<>();
180182
int i = 0;

0 commit comments

Comments
 (0)