Skip to content

ESQL: use the correct upper limit for topN for mv_expand queries #101266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
astefan opened this issue Oct 24, 2023 · 7 comments · May be fixed by #103080
Closed

ESQL: use the correct upper limit for topN for mv_expand queries #101266

astefan opened this issue Oct 24, 2023 · 7 comments · May be fixed by #103080
Assignees
@costin
Labels
:Analytics/ES|QL AKA ESQL >bug low-risk An open issue or test failure that is a low risk to future releases Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@astefan
Copy link
Contributor

astefan commented Oct 24, 2023

Description

Following #100782 in certain scenarios the "default" limit used for the TopN at Lucene level is too broad. This should be aligned with the logic in the Analyzer.AddImplicitLimit rule.
@astefan astefan added >bug :Analytics/ES|QL AKA ESQL low-risk An open issue or test failure that is a low risk to future releases labels Oct 24, 2023
@elasticsearchmachine elasticsearchmachine added the Team:QL (Deprecated) Meta label for query languages team label Oct 24, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL)

@astefan astefan mentioned this issue Oct 24, 2023
Merged
@astefan astefan self-assigned this Nov 13, 2023
@costin costin added this to the 8.12 milestone Nov 16, 2023
@astefan astefan mentioned this issue Dec 6, 2023
Open
@wchaparro wchaparro removed this from the 8.12 milestone Dec 20, 2023
@wchaparro wchaparro added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 2, 2024
@elasticsearchmachine elasticsearchmachine removed the Team:QL (Deprecated) Meta label for query languages team label Jan 2, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@wchaparro wchaparro assigned costin and unassigned astefan Jan 29, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@wchaparro
Copy link
Member

@costin should we still do this one?

@alex-spies
Copy link
Contributor

alex-spies commented Apr 23, 2025 •
edited
Loading

@astefan, this was about the AddDefaultTopN rule, no? I think we iterated on this with @luigidellaquila finally removing it in #121156 because it turned out to be incorrect in general.

@wchaparro , unless Andrei has any objections (or I misunderstood things), I believe this is stale and can be closed.

@astefan
Copy link
Contributor Author

astefan commented Apr 23, 2025

Closing. Thanks @alex-spies

@astefan astefan closed this as completed Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@costin costin

Labels
:Analytics/ES|QL AKA ESQL >bug low-risk An open issue or test failure that is a low risk to future releases Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ESQL: mv_expand default limit fix astefan/elasticsearch
5 participants
@costin @astefan @wchaparro @elasticsearchmachine @alex-spies