Skip to content

ESQL: Safeguards against huge transport requests #112873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alex-spies opened this issue Sep 13, 2024 · 3 comments
Closed

ESQL: Safeguards against huge transport requests #112873

alex-spies opened this issue Sep 13, 2024 · 3 comments
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@alex-spies
Copy link
Contributor

Executing ESQL queries normally requires that the coordinator node and data nodes communicate: the coordinator sends logical plans to the data nodes, the data nodes send pages with results back to the coordinator.

In both directions, the transport message size seems to be unbounded, and there also seems to be no circuit breaker; we've seen cases where particularly large logical plans caused gigabytes of data to be in buffered in the NettyAllocator.

While some issues were addressed in #112008, #111447 and #111973, we should find other situations where this can happen, test it and fix it if needed. I.e.

  • Try to provoke huge LogicalPlans in other ways and test this.
  • Try to provoke huge pages to be sent from data nodes, e.g. super many columns, or with individual values that are huge etc.

This is similar to our HeapAttack tests, but distributed.

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Sep 13, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@alex-spies
Copy link
Contributor Author

This relates to a general problem where transport messages can become arbitrarily large; we should at least double check if this should maybe be solved in Elasticsearch more generally, rather than specifically for ESQL.

@wchaparro
Copy link
Member

Closing as won't do.

@wchaparro wchaparro closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

3 participants