Skip to content

CCS test coverage for index filtering on ES|QL field_caps call #118054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
astefan opened this issue Dec 5, 2024 · 6 comments
Closed

CCS test coverage for index filtering on ES|QL field_caps call #118054

astefan opened this issue Dec 5, 2024 · 6 comments
Assignees
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests

Comments

@astefan
Copy link
Contributor

astefan commented Dec 5, 2024

Description

Following the implementation of field_caps retry mechanism in ES|QL using an index filter, test coverage is needed on CCS-related scenarios.

@astefan astefan added :Analytics/ES|QL AKA ESQL >enhancement >test Issues or PRs that are addressing/adding tests labels Dec 5, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Dec 5, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

1 similar comment
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@smalyshev
Copy link
Contributor

Implemented by #119619

@astefan
Copy link
Contributor Author

astefan commented Jan 10, 2025

I am reopening this one because, while the code in #119619 is great and covers a lot of cases, I believe there are some use cases that need to be checked:

  • is the ccs metadata (when asked for) still correctly returned in all cases where filtering is also used (ccs metadata when clusters are available/unavailable)? Maybe this can be added to the same RequestIndexingFilteringIT that executes all the tests in RequestIndexFilteringTestCase.
  • some good tests are also in CrossClustersQueryIT; some time and research is needed to see which of these are good scenarios to test with index filtering as well.

@astefan astefan reopened this Jan 10, 2025
@smalyshev
Copy link
Contributor

@astefan I'm not sure we have now tests in RequestIndexFilteringIT when any clusters are unavailable. It uses only one remote cluster there, so there's not much place for that. There are other multi-cluster tests (e.g. in CrossClustersQueryIT) but they don't test filters.

I can certainly start with adding metadata checks in RequestIndexFilteringIT. Then I could see if anything else needs to be covered.

@astefan
Copy link
Contributor Author

astefan commented Feb 12, 2025

Thank you @smalyshev. Adding metadata checking to RequestIndexFilteringIT is ok with me. This test class and checks you added with this PR test scenarios where everything is ok from cluster availability point of view with queries that use filters.

In my vision, the same tests from RequestIndexFilteringIT but in the setup used by CrossClusterQueryIT still need to be added. This basically should cover clusters metadata accuracy when filters are used and either one or two _field_caps calls are performed in a CCS scenario where clusters are unavailable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

No branches or pull requests

4 participants