Skip to content

Add support for PIT API in Query watches API #95464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ElenaStoeva opened this issue Apr 21, 2023 · 3 comments
Closed

Add support for PIT API in Query watches API #95464

ElenaStoeva opened this issue Apr 21, 2023 · 3 comments

Comments

@ElenaStoeva
Copy link

Description

Our team, @elastic/platform-deployment-management, is working on replacing the logic for fetching watches from Watcher in Kibana. Currently, Watcher fetches watches by searching the .watches system index, which is not recommended anymore, so we are in the process of replacing this with calls to the Query watches API instead (see elastic/kibana#152142).

We have an open PR for this where we discussed implementation details with @martijnvg. We plan to call the Query watches API using the search_after parameter, sorting on the _seq_no field. We also plan to use the Point In Time API to prevent inconsistent results across pages if a refresh occurs, but the Query watches API doesn't currently support a pit_id parameter so we are not able to utilize the PIT API. Can you please add support for it?

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@martijnvg
Copy link
Member

The request should be able to set PointInTimeBuilder on the search request that the request of this API wraps. And the response of this API should just include the pit that the search response reports.

@ElenaStoeva
Copy link
Author

Closing as we no longer need this - we used pagination to query the watches for the current page only - elastic/kibana#218853.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants