Skip to content

Move aggregation global ordinals loading from search thread to search worker thread. #98667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martijnvg opened this issue Aug 21, 2023 · 2 comments
Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@martijnvg
Copy link
Member

Currently global ordinals often if loaded when determine the maximum ordinal in TermsAggregatorFactory#getMaxOrd(...) as part of determining the execution strategy. This happens on a search thread. Before this wasn't an issue because search threads also executed a search, but since recently the search worker is supposed to perform searching and other heavy search related operations and search threads should only coordinate. Loading global ordinals is a heavy operations and should be performed on a search worker thread. This issue is about ensuring that computing global ordinals in aggregation framework to a search worker thread.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Aug 21, 2023
@original-brownbear
Copy link
Member

Randomly found this one :) Search workers aren't a thing anymore since #111099 -> closing here, search is doing the heavy lifting again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

3 participants