Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: elixir-lang/ex_doc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: elixir-lang/ex_doc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: epub/fix-fatal-errors
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Jan 26, 2024

  1. epub: fix fatal errors while parsing EPUB files 

    After generating the EPUB file for the Elixir docs with this version,
and reviewing the result with `epubcheck`, I got the following summary:

```console
$ epubcheck doc/elixir/Elixir.epub --json elixir_docs.json                                                                                                    (base)

Check finished with errors
Messages: 0 fatals / 141 errors / 0 warnings / 0 infos
```

If you compare the previous result with what we had on #1851

```
Messages: 9 fatals / 425 errors / 0 warnings / 0 infos
```

you can see that now we don't have messages with `fatal` severity and we
have reduced considerably the number of errors =)

I manually checked the generated EPUB on Apple Books and the previous
truncated sections are solved, I don't see the banner _Below is a
rendering of the page up to the first error_ and also the links to
anchor different anchor seems to work.

Fixes: #1851
    @milmazz
    milmazz committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    1d8ee00 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into epub/fix-fatal-errors

    @milmazz
    milmazz committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    014d258 View commit details
    Browse the repository at this point in the history

  3. fix nav layout

    @milmazz
    milmazz committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    146388d View commit details
    Browse the repository at this point in the history
Loading