Skip to content

Conversation

@maryokhin
Copy link
Contributor

I'm half way done, just wanted to put it up for public review. I'll add line comments on why it works without the compat code in the morning..

@kevin-brown
Copy link
Contributor

You're going to need to remove (or edit) maryokhin@9621948, as right now it will close the ticket if we merge this.

@maryokhin
Copy link
Contributor Author

Yes, I'm rebasing now to clean up all the trash commits.

@xordoquy
Copy link
Contributor

xordoquy commented Dec 4, 2014

This looks good to me. Is there more thing to add ?

@lovelydinosaur
Copy link
Contributor

Neat. There will be a bunch of merge conflicts against the 3.1 branch but no biggie.

@lovelydinosaur lovelydinosaur added this to the 3.0.1 Release milestone Dec 4, 2014
@maryokhin
Copy link
Contributor Author

Most moves of packages in Django and Python are handled by a dynamically loaded module django.utils.six.moves which uses a table-like class which remaps paths and imports the correct module. For some reason this powerful feature has only a 2-line description in the docs, so I had to guess around how to use it. Also, because of lazy loading of the modules in django.utils.six.moves IDEs and static analyzers will complain about it.

@maryokhin
Copy link
Contributor Author

Should be good to merge now.

@xordoquy
Copy link
Contributor

xordoquy commented Dec 4, 2014

six.moves is well documented in the six's documentation.
I'll have a closer look at what Django provides with the six library. This should be straight forward but has bitten me in the past.

lovelydinosaur added a commit that referenced this pull request Dec 5, 2014
@lovelydinosaur lovelydinosaur merged commit 65d6cba into encode:master Dec 5, 2014
@lovelydinosaur
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants