NotImplemented -> NotImplementedError #2434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NotImplemented` is a singleton object, not an exception. You should be raising `NotImplementedError` here instead.
|
Good point - could you update this PR to included all the places this is an issue... https://github.com/tomchristie/django-rest-framework/search?utf8=%E2%9C%93&q=NotImplemented |
lovelydinosaur
added a commit
that referenced
this pull request
Jan 19, 2015
NotImplemented is not an exception
lovelydinosaur
changed the title
|
Ignore that - I've gone ahead and added the extra places myself. |
This was referenced Mar 9, 2017
This was referenced Oct 16, 2017
This was referenced Nov 6, 2017
This was referenced Nov 14, 2017
This was referenced Dec 10, 2017
This was referenced Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NotImplementedis a singleton object, not an exception. You should be raisingNotImplementedErrorhere instead.