Skip to content

Conversation

@akhilputhiry
Copy link
Contributor

@akhilputhiry akhilputhiry commented Jun 5, 2016

Closes #4042

@lovelydinosaur
Copy link
Contributor

I haven't dug into it, but I don't believe this would resolve the issue - the problem is likely not that the 500 page isn't returned, but that that it isn't handled correctly and rendered by the browsable API.

If you can confirm that you've ensure the behavior changes before and after this patch, then I'll reopen the ticket, and consider it further.

@akhilputhiry
Copy link
Contributor Author

@tomchristie The 500 page is returned as plain text. In the JS, if response is not html it will redirect. We can handle it in JS side, but the response will be plain text. To generate the original django error page, we need to do this.

I tested this by creating a sample app and its working. Please see the attachment.
screenshot from 2016-06-06 22-50-27

@lovelydinosaur lovelydinosaur reopened this Jun 7, 2016
@lovelydinosaur lovelydinosaur added this to the 3.4.0 Release milestone Jun 7, 2016
@lovelydinosaur
Copy link
Contributor

Thanks for that.
Milestoning this as 3.4.0 to keep it high on the list.

@codecov-io
Copy link

codecov-io commented Jun 13, 2016

Current coverage is 91.43%

No coverage report found for master at 1633a0a.

Powered by Codecov. Last updated by 1633a0a...3a79799

@lovelydinosaur
Copy link
Contributor

lovelydinosaur commented Aug 10, 2016

Looks great, yup! Excellent work. 😄

@lovelydinosaur lovelydinosaur changed the title Modified exception handler to throw django error page in case of 500 error Show Traceback HTML in browsable API Aug 10, 2016
@lovelydinosaur lovelydinosaur merged commit fa4ce50 into encode:master Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants