Skip to content

Fix schema base paths #4611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2016
Merged

Fix schema base paths #4611

merged 1 commit into from
Oct 21, 2016

Conversation

@lovelydinosaur
Copy link
Contributor

Closes #4605

@lovelydinosaur lovelydinosaur added this to the 3.5.1 Release milestone Oct 21, 2016
@lovelydinosaur lovelydinosaur merged commit 0fe0e1e into master Oct 21, 2016
@lovelydinosaur lovelydinosaur deleted the fix-schema-commonpaths branch October 21, 2016 15:59
@pyup-bot pyup-bot mentioned this pull request Oct 22, 2016
Merged
@glarrain
Copy link
Contributor

@tomchristie It seems part of function common_path was extracted from Python's standard library commonpath (https://hg.python.org/cpython/file/3.5/Lib/posixpath.py#l469)
If that's the case, perhaps we should add a reference.

@lovelydinosaur
Copy link
Contributor Author

It's no longer the same implementation (since the stdlib one is useless), but I'd be happy to see a comment outlining what the function does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

3.5.1 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@lovelydinosaur @glarrain