Fallback to more widely supported JS feature sets. #4961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 fixes my issue on Safari. |
kevin-brown
reviewed
Mar 14, 2017
| const formData = new FormData(form.get()[0]); | ||
| for (var [paramKey, paramValue] of formData.entries()) { | ||
| const entries = formEntries(form.get()[0]); | ||
| for (var [paramKey, paramValue] of entries) { |
There was a problem hiding this comment.
for..of support wasn't strong in browsers until very recently: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of#Browser_compatibility
And assignment destructuring is even more recent: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment#Browser_compatibility
There was a problem hiding this comment.
Noted 👍 - Any suggestions on how best to re-write this?
There was a problem hiding this comment.
Something like:
for (var i = 0; i < entries.length; i++) {
var entry = entries[i],
paramKey = entry[0],
paramValue = entry[1];
...
}I think we should probably also drop const and Array.from.
jpadilla
reviewed
Mar 14, 2017
|
|
||
| var entries = [] | ||
|
|
||
| for (var {name, type, value, files, checked, selectedOptions} of Array.from(form.elements)) { |
There was a problem hiding this comment.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4959.