Composed permissions should be lazily evaluated #6463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
force-pushed
the
perms-lazyness
branch
from
113922b to
37688e5
Compare
|
@tomchristie: Tests use |
carltongibson
force-pushed
the
perms-lazyness
branch
from
37688e5 to
32b44d9
Compare
carltongibson
requested review from
lovelydinosaur
and removed request for
xordoquy
|
Seems p. reasonable to me yup. Happy with it when you are. |
|
Ta! |
carltongibson
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
OK, this looks good. I'll just wait for CI. Thanks @FMCorz! Welcome aboard. 🎉
|
Thanks everyone, glad to being able to contribute! |
carltongibson
force-pushed
the
perms-lazyness
branch
from
32b44d9 to
7c742dc
Compare
oyvindkolbu
added a commit
to unioslo/mreg
that referenced
this pull request
Mar 28, 2019
Also adds a small nice feature which is handy now when coding authorization: encode/django-rest-framework#6463 While here update the other requirements to latest.
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When composing permissions, all permissions are evaluated even when the outcome is already set. This can lead to errors when the order of the permission was logically set.
For example with
IsReadonly | IsAssumingNotReadonly, ifIsReadonlyrespondsTrueforGETrequests, logicallyIsAssumingNotReadonlycan assume that the method is notGET. Presently, this is not the case asIsAssumingNotReadonlyis being evaluated.The patch suggests switching to lazy
orandandinstead of the bitwise operators.(Initial report)