Skip to content

DateField to_representation can handle str and empty values. Fixes #2656, #2687. #2869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2015
Merged

DateField to_representation can handle str and empty values. Fixes #2656, #2687. #2869

merged 1 commit into from
May 1, 2015

Conversation

@ryangallen
Copy link

Let me know if these tests and fixes aren't appropriate.

@ryangallen ryangallen mentioned this pull request May 1, 2015
Closed
@lovelydinosaur lovelydinosaur added this to the 3.1.2 Release milestone May 1, 2015
lovelydinosaur added a commit that referenced this pull request May 1, 2015
@lovelydinosaur
Merge pull request #2869 from ryangallen/datefield
abcd6f2 
DateField to_representation can handle str and empty values. Fixes #2656, #2687.
@lovelydinosaur lovelydinosaur merged commit abcd6f2 into encode:master May 1, 2015
@lovelydinosaur
Copy link
Contributor

Nice work!

@ryangallen ryangallen deleted the datefield branch May 3, 2015 17:25
@mdentremont
Copy link
Contributor

@tomchristie Do you know if a similar change should be made for the DateTimeField and the TimeField? I started looking into this but quickly ran into some trickyness with timezones in relation to strptime.

@lovelydinosaur
Copy link
Contributor

@mdentremont Don't know. May be worth looking at.

@mjparker777 mjparker777 mentioned this pull request Dec 12, 2015
Closed
@jpadilla jpadilla mentioned this pull request Dec 13, 2015
Merged
@xordoquy xordoquy mentioned this pull request Mar 22, 2016
Closed
@pyup-bot pyup-bot mentioned this pull request Oct 22, 2016
Merged
@pyup-bot pyup-bot mentioned this pull request Oct 30, 2016
Merged
@pyup-bot pyup-bot mentioned this pull request Feb 26, 2017
Merged
This was referenced Mar 9, 2017
Closed
Closed
Closed
@pyup-bot pyup-bot mentioned this pull request Jun 7, 2017
Closed
@pyup-bot pyup-bot mentioned this pull request Sep 19, 2017
Merged
This was referenced Oct 6, 2017
Closed
Closed
Closed
This was referenced Oct 16, 2017
Closed
Closed
Closed
Closed
This was referenced Nov 6, 2017
Closed
Closed
This was referenced Nov 6, 2017
Closed
Closed
Closed
This was referenced Nov 14, 2017
Closed
Closed
This was referenced Dec 10, 2017
Closed
Closed
This was referenced Dec 20, 2017
Closed
Closed
Closed
@pyup-bot pyup-bot mentioned this pull request Feb 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

3.1.2 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@ryangallen @lovelydinosaur @mdentremont