Don't recreate resources when editing plugin scenes

Previously, opening and saving parameter_block.tscn (for example) in the editor
would cause its StyleBoxFlat resource to be replaced by an identical
sub_resource with a new unique identifier. This is because its _ready()
function runs when the scene is being edited, and previously would
unconditionally re-set the stylebox.

This either causes needless diff churn, or requires extra work by the developer
to discard that hunk.

In each case, guard the change with `node_is_part_of_edited_scene`, and
remove it from the saved scene.

Author: wjt

addons/block_code/ui/block_canvas/block_canvas.gd

@@ -2,6 +2,8 @@
 class_name BlockCanvas
 extends MarginContainer
 
+const Util = preload("res://addons/block_code/ui/util.gd")
+
 const EXTEND_MARGIN: float = 800
 const BLOCK_AUTO_PLACE_MARGIN: Vector2 = Vector2(25, 8)
 const DEFAULT_WINDOW_MARGIN: Vector2 = Vector2(25, 25)
@@ -45,7 +47,7 @@ signal replace_block_code
 
 
 func _ready():
-	if not _open_scene_button.icon:
+	if not _open_scene_button.icon and not Util.node_is_part_of_edited_scene(self):
 		_open_scene_button.icon = _open_scene_icon
 	_populate_block_scenes_by_class()
 

addons/block_code/ui/block_canvas/block_canvas.tscn

@@ -1,20 +1,8 @@
-[gd_scene load_steps=5 format=3 uid="uid://c6vumewgnfquy"]
+[gd_scene load_steps=3 format=3 uid="uid://c6vumewgnfquy"]
 
 [ext_resource type="Script" path="res://addons/block_code/ui/block_canvas/block_canvas.gd" id="1_tk8h2"]
 [ext_resource type="Texture2D" uid="uid://cmusxj1ppspnp" path="res://addons/block_code/block_code_node/block_code_node.svg" id="2_710vn"]
 
-[sub_resource type="Image" id="Image_1nubg"]
-data = {
-"data": PackedByteArray(255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 255, 255, 0, 255, 94, 94, 127, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 255, 255, 0, 255, 93, 93, 255, 255, 94, 94, 127, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 255, 255, 0, 255, 93, 93, 255, 255, 93, 93, 255, 255, 94, 94, 127, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 255, 255, 0, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 94, 94, 127, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 93, 93, 231, 255, 94, 94, 54, 255, 94, 94, 57, 255, 93, 93, 233, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 231, 255, 94, 94, 54, 255, 94, 94, 57, 255, 93, 93, 233, 255, 93, 93, 255, 255, 93, 93, 255, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 97, 97, 42, 255, 255, 255, 0, 255, 255, 255, 0, 255, 97, 97, 42, 255, 93, 93, 233, 255, 93, 93, 232, 255, 93, 93, 41, 255, 255, 255, 0, 255, 255, 255, 0, 255, 97, 97, 42, 255, 93, 93, 233, 255, 93, 93, 232, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 96, 96, 45, 255, 93, 93, 44, 255, 255, 255, 0, 255, 97, 97, 42, 255, 97, 97, 42, 255, 255, 255, 0, 255, 96, 96, 45, 255, 93, 93, 44, 255, 255, 255, 0, 255, 97, 97, 42, 255, 97, 97, 42, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 96, 96, 45, 255, 93, 93, 235, 255, 94, 94, 234, 255, 95, 95, 43, 255, 255, 255, 0, 255, 255, 255, 0, 255, 96, 96, 45, 255, 93, 93, 235, 255, 94, 94, 234, 255, 95, 95, 43, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 93, 93, 235, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 233, 255, 95, 95, 59, 255, 96, 96, 61, 255, 93, 93, 235, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 233, 255, 95, 95, 59, 255, 96, 96, 61, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 93, 93, 255, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0, 255, 255, 255, 0),
-"format": "RGBA8",
-"height": 16,
-"mipmaps": false,
-"width": 16
-}
-
-[sub_resource type="ImageTexture" id="ImageTexture_jgo72"]
-image = SubResource("Image_1nubg")
-
 [node name="BlockCanvas" type="MarginContainer"]
 anchors_preset = 15
 anchor_right = 1.0
@@ -142,7 +130,6 @@ layout_mode = 2
 size_flags_horizontal = 4
 theme_type_variation = &"InspectorActionButton"
 text = "Open in Editor"
-icon = SubResource("ImageTexture_jgo72")
 
 [node name="ReplaceBlockCodeButton" type="Button" parent="SelectedNodeWithBlockCodeBox/ButtonsBox"]
 unique_name_in_owner = true

addons/block_code/ui/blocks/parameter_block/parameter_block.gd

@@ -2,6 +2,8 @@
 class_name ParameterBlock
 extends Block
 
+const Util = preload("res://addons/block_code/ui/util.gd")
+
 @export var block_format: String = ""
 @export var statement: String = ""
 @export var variant_type: Variant.Type
@@ -19,10 +21,11 @@ func _ready():
 	super()
 
 	block_type = Types.BlockType.VALUE
-	var new_panel = _panel.get_theme_stylebox("panel").duplicate()
-	new_panel.bg_color = color
-	new_panel.border_color = color.darkened(0.2)
-	_panel.add_theme_stylebox_override("panel", new_panel)
+	if not Util.node_is_part_of_edited_scene(self):
+		var new_panel = _panel.get_theme_stylebox("panel").duplicate()
+		new_panel.bg_color = color
+		new_panel.border_color = color.darkened(0.2)
+		_panel.add_theme_stylebox_override("panel", new_panel)
 
 	format()
 

addons/block_code/ui/blocks/parameter_block/parameter_block.tscn

@@ -1,19 +1,8 @@
-[gd_scene load_steps=4 format=3 uid="uid://clipm2dd28jde"]
+[gd_scene load_steps=3 format=3 uid="uid://clipm2dd28jde"]
 
 [ext_resource type="Script" path="res://addons/block_code/ui/blocks/parameter_block/parameter_block.gd" id="1_0hajy"]
 [ext_resource type="PackedScene" uid="uid://c7puyxpqcq6xo" path="res://addons/block_code/ui/blocks/utilities/drag_drop_area/drag_drop_area.tscn" id="2_gy5co"]
 
-[sub_resource type="StyleBoxFlat" id="StyleBoxFlat_dbera"]
-bg_color = Color(1, 1, 1, 1)
-border_width_left = 3
-border_width_top = 3
-border_width_right = 3
-border_width_bottom = 3
-corner_radius_top_left = 16
-corner_radius_top_right = 16
-corner_radius_bottom_right = 16
-corner_radius_bottom_left = 16
-
 [node name="ParameterBlock" type="MarginContainer"]
 offset_right = 16.0
 offset_bottom = 8.0
@@ -27,7 +16,6 @@ block_type = 3
 [node name="Panel" type="Panel" parent="."]
 unique_name_in_owner = true
 layout_mode = 2
-theme_override_styles/panel = SubResource("StyleBoxFlat_dbera")
 
 [node name="DragDropArea" parent="." instance=ExtResource("2_gy5co")]
 layout_mode = 2

addons/block_code/ui/picker/categories/block_category_button.gd

@@ -2,6 +2,8 @@
 class_name BlockCategoryButton
 extends MarginContainer
 
+const Util = preload("res://addons/block_code/ui/util.gd")
+
 signal selected
 
 var category: BlockCategory
@@ -14,10 +16,10 @@ func _ready():
 	if not category:
 		category = BlockCategory.new("Example", Color.RED)
 
-	var new_stylebox: StyleBoxFlat = _panel.get_theme_stylebox("panel").duplicate()
-	new_stylebox.bg_color = category.color
-
-	_panel.add_theme_stylebox_override("panel", new_stylebox)
+	if not Util.node_is_part_of_edited_scene(self):
+		var new_stylebox: StyleBoxFlat = _panel.get_theme_stylebox("panel").duplicate()
+		new_stylebox.bg_color = category.color
+		_panel.add_theme_stylebox_override("panel", new_stylebox)
 
 	_label.text = category.name
 

addons/block_code/ui/picker/categories/block_category_button.tscn

@@ -1,14 +1,7 @@
-[gd_scene load_steps=7 format=3 uid="uid://bdtetj0gs45hv"]
+[gd_scene load_steps=6 format=3 uid="uid://bdtetj0gs45hv"]
 
 [ext_resource type="Script" path="res://addons/block_code/ui/picker/categories/block_category_button.gd" id="1_pxxnl"]
 
-[sub_resource type="StyleBoxFlat" id="StyleBoxFlat_eogpc"]
-bg_color = Color(1, 0, 0, 1)
-corner_radius_top_left = 100
-corner_radius_top_right = 100
-corner_radius_bottom_right = 100
-corner_radius_bottom_left = 100
-
 [sub_resource type="StyleBoxEmpty" id="StyleBoxEmpty_ousiv"]
 
 [sub_resource type="StyleBoxFlat" id="StyleBoxFlat_fyk0j"]
@@ -39,7 +32,6 @@ theme_override_constants/margin_bottom = 8
 [node name="Panel" type="Panel" parent="HBoxContainer/MarginContainer"]
 unique_name_in_owner = true
 layout_mode = 2
-theme_override_styles/panel = SubResource("StyleBoxFlat_eogpc")
 
 [node name="Label" type="Label" parent="HBoxContainer"]
 unique_name_in_owner = true